Date: Fri, 12 May 2017 03:32:27 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 192528] pwd_mkdb fails if /etc/shells contains duplicates Message-ID: <bug-192528-8-fkXUMh9d4R@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-192528-8@https.bugs.freebsd.org/bugzilla/> References: <bug-192528-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D192528 --- Comment #7 from Kyle Evans <bsdports@kyle-evans.net> --- Hi, I've created the following review for this: https://reviews.freebsd.org/D10= 690 memset()'ing the line isn't necessary every iteration since fgets() should = just overwrite as necessary and null-terminate properly. I've also hit the second case where a line ends in a comment or with no valid shell. Cheers, Kyle Evans --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192528-8-fkXUMh9d4R>