Date: Tue, 4 Apr 2006 15:29:51 +0000 (UTC) From: Chuck Lever <cel@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/nfsserver nfs_srvsubs.c Message-ID: <200604041529.k34FTqOD062832@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
cel 2006-04-04 15:29:51 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_6)
sys/nfsserver nfs_srvsubs.c
Log:
rick says:
The following bug was just identified in OpenBSD and it looks like the same
bug exists in the other BSDen NFS servers.
A Linux client (don't know which version, but you can look at
http://bugzilla.kernel.org/show_bug.cgi?id=6256)
does a Setattr of mtime to the server's time, where the file is mode 0664 and
the client user has group access (ie. caller is not the file owner).
The BSD servers fail the Setattr with EPERM, since the VA_UTIMES_NULL flag
isn't set before doing the VOP_SETATTR.
It seems to me that this should be allowed, since it is allowed for a local
utimes(2). If so, the fix is to set VA_UTIMES_NULL for the
"set-time-to-server-time" cases of setting atime and/or mtime.
MFC of revision 1.140 to RELENG_6.
Submitted by: rick@snowhite.cis.uoguelph.ca
Reviewed by: cel
Approved by: re (scottl), silby
Revision Changes Path
1.136.2.2 +6 -0 src/sys/nfsserver/nfs_srvsubs.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200604041529.k34FTqOD062832>