Date: Sat, 7 May 2016 11:34:51 +0000 From: "nvass-gmx.com (Nikos Vassiliadis)" <phabric-noreply@FreeBSD.org> To: freebsd-virtualization@freebsd.org Subject: [Differential] D1944: PF and VIMAGE fixes Message-ID: <c7957051908350d4f19c7fc4d7ad7695@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-clct73g5zt63yh3lvwzr-req@FreeBSD.org> References: <differential-rev-PHID-DREV-clct73g5zt63yh3lvwzr-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
nvass-gmx.com added a comment. Thanks for taking a look Kristof, I believe all your points are valid. Thing is that all eventhandlers need a more thorough look. They don't work as they should; be it virtualized or not, be it a VIMAGE or GENERIC kernel. I am trying to take a look but I haven't thrown enough time to it. INLINE COMMENTS > @kristof wrote in sys/netpfil/pf/pf_if.c:130 > I don't understand why this is required. Surely if an ifnet lives in V_ifnet (so, lives in the current vnet) ifp->if_vnet is always going to be curvnet? You're correct. It is plain wrong REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farrokhi, julian, robak, freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c7957051908350d4f19c7fc4d7ad7695>