From owner-freebsd-ports@FreeBSD.ORG Tue Aug 31 21:39:54 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F275106573B for ; Tue, 31 Aug 2010 21:39:54 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id EDA898FC16 for ; Tue, 31 Aug 2010 21:39:53 +0000 (UTC) Received: by ewy4 with SMTP id 4so4420707ewy.13 for ; Tue, 31 Aug 2010 14:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=H2mUA/hStcNQBiF2kGr4Hs1mE3qVWzmKq54//ZyPOpw=; b=BomLXvmQUs+S60wBmXScNLeXhMZKVr7kkNcfIbU6YdRgwmh+ShKtVIK38oFXWGWkN3 1Dx+hx1uIghUlBXtCrBzuy8YEljCvlIePT42aBQt7yUV4JJYelpC9deP3DeuXU26CPXh xIqcpipZO5IFsY1ehvJBZifyJohZD4sEWn1Ts= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=bpDZF+8V2hq//K4iat+IE0pw01kIcpTAmOz+8cA9zum7F2o/KkP/4fM5oG1KqT44Ig nzf1x2KMFKciyM/uht/f+r3SPOrpATjSBPPL0QBEX3sO+OwqHveVY9d5McGZm7QYVnoL OxM3lAfNxxlLx9twpobOjdvjRhX4M0AFQsbpk= Received: by 10.213.105.77 with SMTP id s13mr10496480ebo.50.1283290792993; Tue, 31 Aug 2010 14:39:52 -0700 (PDT) Received: from centel.dataix.local (adsl-99-181-137-20.dsl.klmzmi.sbcglobal.net [99.181.137.20]) by mx.google.com with ESMTPS id a48sm14774892eei.13.2010.08.31.14.39.51 (version=SSLv3 cipher=RC4-MD5); Tue, 31 Aug 2010 14:39:52 -0700 (PDT) Sender: "J. Hellenthal" Message-ID: <4C7D76A6.7080401@DataIX.net> Date: Tue, 31 Aug 2010 17:39:50 -0400 From: jhell User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.8) Gecko/20100806 Lightning/1.0b1 Thunderbird MIME-Version: 1.0 To: bf1783@gmail.com References: In-Reply-To: X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "b. f." , freebsd-ports@FreeBSD.org Subject: Re: math/blas linking to gfortran with LDADD?= -lgfortran X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2010 21:39:54 -0000 Looking closer at the math/blas & math/lapack ports: This statement does not make any sense. The logic is backwards for every instance. And WITH_PROFILE would do. .if !(defined(NOPROFILE) || defined(NO_PROFILE) || defined(WITHOUT_PROFILE)) PLIST_FILES+= lib/libblas_p.a .endif Which is basically saying: Add that profile lib if NOPROFILE is not defined "_p is a profiled lib why would you want to install this if the admin has NOT defined NOPROFILE? Second add that lib if NO_PROFILE is defined ? see previous question still doing the wrong thing here. Third add that lib if WITHOUT_PROFILE is defined ? see previous two question still not doing the right thing here. Simple following would do. .if (defined(WITH_PROFILE) PLIST_FILES+= lib/libblas_p.a ,endif Then if it is really a concern that this has to default to on, then use the options framework to present that to the user. At least in this instance the user will at least know whats going on. Regards, -- jhell,v