From owner-svn-ports-all@FreeBSD.ORG  Sun Apr 19 17:34:44 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 6564A912; Sun, 19 Apr 2015 17:34:44 +0000 (UTC)
Date: Sun, 19 Apr 2015 17:34:44 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kurt Jaeger <pi@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r384307 - head/math/coinmp
Message-ID: <20150419173444.GA77207@FreeBSD.org>
References: <201504191716.t3JHGwk2069000@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201504191716.t3JHGwk2069000@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Apr 2015 17:34:44 -0000

On Sun, Apr 19, 2015 at 05:16:58PM +0000, Kurt Jaeger wrote:
> New Revision: 384307
> URL: https://svnweb.freebsd.org/changeset/ports/384307
> 
> Log:
>   math/coinmp: change comma, target for check/test etc as suggested by danfe
>   
>   PR:		199502
>   Submitted by:	danfe

Wrong attribution; the PR was not submitted by me.

> [...]
>  check regression-test test: build
> -	@(cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} \
> -	${MAKE_ARGS} test)
> +	${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} \
> +	${MAKE_ARGS} test -C ${WRKSRC}

Wrong indentation.  I'd appreciate if you'd waited for my final review,
given that I've suggested these improvements.

This is partially my fault since I didn't explain Carlos that PR was not
necessary for this at all clearly enough. :(

./danfe