Date: Fri, 06 Jun 2008 08:27:06 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: sobomax@freebsd.org Cc: danfe@freebsd.org, src-committers@freebsd.org, flz@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, sgk@troutmask.apl.washington.edu, wb@freebie.xs4all.nl, remko@freebsd.org, cokane@freebsd.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c pkg_add.1 src/usr.sbin/pkg_install/create main.c pkg_create.1 src/usr.sbin/pkg_install/delete main.c pkg_delete.1 src/usr.sbin/pkg_install/info main.c pkg_info.1 ... Message-ID: <20080606.082706.-345494353.imp@bsdimp.com> In-Reply-To: <4846F30A.5070204@FreeBSD.org> References: <20080604192955.GA46284@troutmask.apl.washington.edu> <4846EF10.1020803@FreeBSD.org> <4846F30A.5070204@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
: It's not your call either. We have style(9), which says: Thus quote he from the holy book of style, section nine, verses 127-134 : For consistency, getopt(3) should be used to parse options. Options : should be sorted in the getopt(3) call and the switch statement, : unless : parts of the switch cascade. Elements in a switch statement that : cascade : should have a FALLTHROUGH comment. Numerical arguments should be : checked : for accuracy. Code that cannot be reached should have a : NOTREACHED com- : ment. : : There is nothing about getopt_long(3) being acceptable : replacement/addition to the getopt(3). Style(9) is about documenting the normative style of the project. While we prefer people to use it, it isn't religious dogma. getopt_long() is in the spirit of style(9) which is trying to say "don't be a dumb-ass and write your own argument parsing routine." Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080606.082706.-345494353.imp>