From owner-svn-src-all@freebsd.org Fri Oct 18 03:01:22 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AF96D164CC7; Fri, 18 Oct 2019 03:01:22 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46vW5G2WSJz43gX; Fri, 18 Oct 2019 03:01:22 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3B3D125BC; Fri, 18 Oct 2019 03:01:22 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x9I31M8t064002; Fri, 18 Oct 2019 03:01:22 GMT (envelope-from cem@FreeBSD.org) Received: (from cem@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x9I31M9I064001; Fri, 18 Oct 2019 03:01:22 GMT (envelope-from cem@FreeBSD.org) Message-Id: <201910180301.x9I31M9I064001@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: cem set sender to cem@FreeBSD.org using -f From: Conrad Meyer Date: Fri, 18 Oct 2019 03:01:22 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r353714 - head/sys/dev/nvdimm X-SVN-Group: head X-SVN-Commit-Author: cem X-SVN-Commit-Paths: head/sys/dev/nvdimm X-SVN-Commit-Revision: 353714 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2019 03:01:22 -0000 Author: cem Date: Fri Oct 18 03:01:21 2019 New Revision: 353714 URL: https://svnweb.freebsd.org/changeset/base/353714 Log: nvdimm_e820: Fix braino in size=all SPA hint The sentinel value for "use the rest of the region," -1, isn't zero modulo PAGE_SIZE. Relax the check to permit the intended special value. X-MFC-With: r353110 Sponsored by: Dell EMC Isilon Modified: head/sys/dev/nvdimm/nvdimm_e820.c Modified: head/sys/dev/nvdimm/nvdimm_e820.c ============================================================================== --- head/sys/dev/nvdimm/nvdimm_e820.c Fri Oct 18 02:25:30 2019 (r353713) +++ head/sys/dev/nvdimm/nvdimm_e820.c Fri Oct 18 03:01:21 2019 (r353714) @@ -138,8 +138,8 @@ nvdimm_e820_create_spas(device_t dev) hintaddr = (vm_paddr_t)hintaddrl; hintsize = (vm_size_t)hintsizel; - if ((hintaddr & PAGE_MASK) != 0 || (hintsize & PAGE_MASK) != 0) - { + if ((hintaddr & PAGE_MASK) != 0 || + ((hintsize & PAGE_MASK) != 0 && hintsize != HINT_ALL)) { device_printf(dev, "hint.nvdimm_spa.%u addr or size " "not page aligned\n", i); continue;