Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Jan 2015 15:19:19 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r277301 - head/sys/fs/ext2fs
Message-ID:  <201501171519.t0HFJJIx001602@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Sat Jan 17 15:19:18 2015
New Revision: 277301
URL: https://svnweb.freebsd.org/changeset/base/277301

Log:
  ext2: cosmetical issues
  
  Minor sorting and note when the cases are expected to fall through.
  
  MFC after:	1 week

Modified:
  head/sys/fs/ext2fs/ext2_hash.c

Modified: head/sys/fs/ext2fs/ext2_hash.c
==============================================================================
--- head/sys/fs/ext2fs/ext2_hash.c	Sat Jan 17 14:44:59 2015	(r277300)
+++ head/sys/fs/ext2fs/ext2_hash.c	Sat Jan 17 15:19:18 2015	(r277301)
@@ -196,10 +196,10 @@ ext2_prep_hashbuf(const char *src, int s
 {
 	uint32_t padding = slen | (slen << 8) | (slen << 16) | (slen << 24);
 	uint32_t buf_val;
-	int len, i;
-	int buf_byte;
 	const unsigned char *ubuf = (const unsigned char *)src;
 	const signed char *sbuf = (const signed char *)src;
+	int len, i;
+	int buf_byte;
 
 	if (slen > dlen)
 		len = dlen;
@@ -265,6 +265,7 @@ ext2_htree_hash(const char *name, int le
 	switch (hash_version) {
 	case EXT2_HTREE_TEA_UNSIGNED:
 		unsigned_char = 1;
+		/* FALLTHROUGH */
 	case EXT2_HTREE_TEA:
 		while (len > 0) {
 			ext2_prep_hashbuf(name, len, data, 16, unsigned_char);
@@ -277,11 +278,13 @@ ext2_htree_hash(const char *name, int le
 		break;
 	case EXT2_HTREE_LEGACY_UNSIGNED:
 		unsigned_char = 1;
+		/* FALLTHROUGH */
 	case EXT2_HTREE_LEGACY:
 		major = ext2_legacy_hash(name, len, unsigned_char);
 		break;
 	case EXT2_HTREE_HALF_MD4_UNSIGNED:
 		unsigned_char = 1;
+		/* FALLTHROUGH */
 	case EXT2_HTREE_HALF_MD4:
 		while (len > 0) {
 			ext2_prep_hashbuf(name, len, data, 32, unsigned_char);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201501171519.t0HFJJIx001602>