Date: Wed, 27 Feb 2019 15:34:58 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Niclas Zeising <zeising@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r494049 - in head/devel/imake: . files Message-ID: <20190227153458.GA57893@FreeBSD.org> In-Reply-To: <FF1C3C24-3E8B-4B94-AB7C-212B3C0CE661@cschubert.com> References: <201902271255.x1RCtIJs066388@repo.freebsd.org> <20190227131242.GA6386@FreeBSD.org> <FF1C3C24-3E8B-4B94-AB7C-212B3C0CE661@cschubert.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 27, 2019 at 06:53:10AM -0800, Cy Schubert wrote: > Making unrelated changes in the same commit, even when documented, makes > parsing of the patch necessary for those who might need to analyze a patch > months after the fact. Of course. But in this case it was so obviously wrong that I kindly want to remind all of us that tidy commit history is essential to work with our code and ports efficiently, and "svn st" with "svn diff" prior to commit can save us from making this silly mistakes. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190227153458.GA57893>