Date: Thu, 4 Jan 2018 21:42:27 -0500 From: Steve Wills <swills@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457907 - in head/net/rubygem-grpc: . files Message-ID: <c0ae74b4-6623-f8c6-e6c8-5787b57389bf@FreeBSD.org> In-Reply-To: <20180103075744.GA2731@FreeBSD.org> References: <201801021606.w02G6xxJ033897@repo.freebsd.org> <20180103075744.GA2731@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On 01/03/2018 02:57, Alexey Dokuchaev wrote:
>
> Would you consider patching grpc.gemspec with sed(1) instead? It is
> not particularly pretty, but not as ugly as 10K pre-generated binary
> file with messed up svn properties.
>
> It also places ${RM} -r of those files and directories and subsequent
> grpc.gemspec fixup closer together (rather than one part done in the
> `post-extract' target and fixup ... well, somewhere else).
>
> It produces exactly the same result as current `files/grpc.gemspec'.
I generally don't like to use REINPLACE_CMD when a patch will do,
because it can silently stop working, but in this case it works well and
seems like a better alternative.
So sure, contact the maintainer with a patch, I'm sure he'll approve it.
Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c0ae74b4-6623-f8c6-e6c8-5787b57389bf>