From owner-svn-src-all@freebsd.org Wed May 18 11:01:52 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D711B409CE; Wed, 18 May 2016 11:01:52 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id ECEDE1276; Wed, 18 May 2016 11:01:51 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 3AE1525D386D; Wed, 18 May 2016 11:01:48 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 7C2CFD1F8BC; Wed, 18 May 2016 11:01:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id N_Ol9KC8jR-s; Wed, 18 May 2016 11:01:44 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:10a6:9e53:5e9c:c191] (unknown [IPv6:fde9:577b:c1a9:4410:10a6:9e53:5e9c:c191]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 62975D1F8A6; Wed, 18 May 2016 11:01:44 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r300113 - in head/sys: conf kern net sys From: "Bjoern A. Zeeb" In-Reply-To: <201605180435.u4I4ZwYh025096@repo.freebsd.org> Date: Wed, 18 May 2016 11:01:24 +0000 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201605180435.u4I4ZwYh025096@repo.freebsd.org> To: Scott Long X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2016 11:01:52 -0000 > On 18 May 2016, at 04:35 , Scott Long wrote: >=20 > Author: scottl > Date: Wed May 18 04:35:58 2016 > New Revision: 300113 > URL: https://svnweb.freebsd.org/changeset/base/300113 >=20 > Log: > Import the 'iflib' API library for network drivers. =46rom the = author: >=20 > "iflib is a library to eliminate the need for frequently duplicated = device > independent logic propagated (poorly) across many network drivers." >=20 > Participation is purely optional. The IFLIB kernel config option is > provided for drivers that want to transition between legacy and iflib > modes of operation. ixl and ixgbe driver conversions will be = committed > shortly. We hope to see participation from the Broadcom and maybe > Chelsio drivers in the near future. >=20 > Submitted by: mmacy@nextbsd.org > Reviewed by: gallatin > Differential Revision: D5211 >=20 > Added: > head/sys/net/ifdi_if.m (contents, props changed) > head/sys/net/iflib.c (contents, props changed) > head/sys/net/iflib.h (contents, props changed) > head/sys/net/mp_ring.c (contents, props changed) > head/sys/net/mp_ring.h (contents, props changed) > Modified: > head/sys/conf/files > head/sys/conf/options > head/sys/kern/device_if.m > head/sys/kern/kern_mbuf.c > head/sys/kern/subr_taskqueue.c > head/sys/net/if.c > head/sys/net/if_var.h > head/sys/sys/_task.h > head/sys/sys/mbuf.h > head/sys/sys/taskqueue.h Ignoring style for a moment, this broke builds; just as examples: mips XLP cc1: warnings being treated as errors /scratch/tmp/bz/head.svn/sys/net/mp_ring.c: In function = 'drain_ring_lockless': /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:204: warning: implicit = declaration of function 'atomic_cmpset_64' /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:204: warning: nested extern = declaration of 'atomic_cmpset_64' [-Wnested-externs] /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:231: warning: implicit = declaration of function 'atomic_cmpset_acq_64' /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:231: warning: nested extern = declaration of 'atomic_cmpset_acq_64' [-Wnested-externs] /scratch/tmp/bz/head.svn/sys/net/mp_ring.c: In function = 'ifmp_ring_enqueue': /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:456: warning: implicit = declaration of function 'atomic_cmpset_rel_64' /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:456: warning: nested extern = declaration of 'atomic_cmpset_rel_64' [-Wnested-externs] --- mp_ring.o --- *** [mp_ring.o] Error code 1 bmake[5]: stopped in = /storage/head/obj/mips.mips/scratch/tmp/bz/head.svn/sys/XLP powerpc LINT: cc1: warnings being treated as errors /scratch/tmp/bz/head.svn/sys/net/iflib.c: In function = '_iflib_fl_refill': /scratch/tmp/bz/head.svn/sys/net/iflib.c:1538: warning: comparison is = always true due to limited range of data type /scratch/tmp/bz/head.svn/sys/net/iflib.c: In function = 'iflib_fl_bufs_free': /scratch/tmp/bz/head.svn/sys/net/iflib.c:1667: warning: comparison is = always true due to limited range of data type --- iflib.o --- *** [iflib.o] Error code 1 bmake[5]: stopped in = /storage/head/obj/powerpc.powerpc/scratch/tmp/bz/head.svn/sys/LINT cc1: warnings being treated as errors /scratch/tmp/bz/head.svn/sys/net/mp_ring.c: In function = 'drain_ring_lockless': /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:204: warning: implicit = declaration of function 'atomic_cmpset_64' /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:204: warning: nested extern = declaration of 'atomic_cmpset_64' [-Wnested-externs] /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:231: warning: implicit = declaration of function 'atomic_cmpset_acq_64' /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:231: warning: nested extern = declaration of 'atomic_cmpset_acq_64' [-Wnested-externs] /scratch/tmp/bz/head.svn/sys/net/mp_ring.c: In function = 'ifmp_ring_enqueue': /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:456: warning: implicit = declaration of function 'atomic_cmpset_rel_64' /scratch/tmp/bz/head.svn/sys/net/mp_ring.c:456: warning: nested extern = declaration of 'atomic_cmpset_rel_64' [-Wnested-externs] --- mp_ring.o --- *** [mp_ring.o] Error code 1 =E2=80=A6 =E2=80=94=20 Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."