From owner-cvs-src@FreeBSD.ORG  Sun Aug 22 02:32:15 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5160216A4CE; Sun, 22 Aug 2004 02:32:15 +0000 (GMT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id F304D43D31; Sun, 22 Aug 2004 02:32:14 +0000 (GMT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i7M2U7lH098751;
	Sat, 21 Aug 2004 22:30:07 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)i7M2U3MT098746;
	Sat, 21 Aug 2004 22:30:03 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Sat, 21 Aug 2004 22:30:03 -0400 (EDT)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: Brian Fundakowski Feldman <green@FreeBSD.org>
In-Reply-To: <20040822015800.GE784@green.homeunix.org>
Message-ID: <Pine.NEB.3.96L.1040821222342.95496C-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Alan Cox <alc@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Alan Cox <alc@cs.rice.edu>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm vm_fault.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Aug 2004 02:32:15 -0000


On Sat, 21 Aug 2004, Brian Fundakowski Feldman wrote:

> > > #1. Lock order reversal.  Giant is acquired after the map read lock.
> > 
> > No, that is the order it has been in for months.  The other functions
> > that acquire a map lock and Giant do the same.
> 
> Giant can never be acquired after another lock has been acquired :-(

Actually, that's not quite accurate.  Take a look at the relationship
between lockmgr/sx locks and Giant, for example.

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Principal Research Scientist, McAfee Research