Date: Thu, 3 Apr 1997 18:55:52 +1000 From: Bruce Evans <bde@zeta.org.au> To: ache@freefall.freebsd.org, jdp@polstra.com Cc: bde@freebsd.org, cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-user@freefall.freebsd.org Subject: Re: cvs commit: src Makefile Message-ID: <199704030855.SAA09070@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> Modified: . Makefile >> Log: >> For csu/i386 add "all" before "beforeinstall", because "beforeinstall" >> wants to install "all" targets which not exist at this stage > >I think the real problem was in "src/lib/csu/i386/Makefile". >Bruce's recent commit accidentally (I think) deleted the >"realinstall:" line, which merged the "realinstall" actions into the >"beforeinstall" actions. The log entry just said he was >"simplifying" the Makefile, so I don't think he really meant to >change its behavior. No, I meant to change it. "realinstall" should be a private target. Anyway, it should only be used to stop the default realinstall target being used, not just to install miscellaneous files. "beforeinstall" is not the best name for the target for installing miscellaneous files, but it is generally used. The problem is that "make includes" assumes that the beforeinstall target installs all headers and nothing harmful. It would be better to have a "headerinstall" target in each Makefile that installs headers. However, `make headerinstall' would probably be too slow to use for `make world' - traversing the tree would be inefficient. I never use the includes target, so I didn't notice the problem. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199704030855.SAA09070>