From owner-svn-ports-head@freebsd.org Sat Aug 13 14:39:39 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C179BB8FD8; Sat, 13 Aug 2016 14:39:39 +0000 (UTC) (envelope-from brnrd@FreeBSD.org) Received: from smtp02.qsp.nl (smtp02.qsp.nl [193.254.214.163]) by mx1.freebsd.org (Postfix) with ESMTP id AED3214DA; Sat, 13 Aug 2016 14:39:38 +0000 (UTC) (envelope-from brnrd@FreeBSD.org) Received: from smtp02.qsp.nl (localhost [127.0.0.1]) by smtp02.qsp.nl (Postfix) with ESMTP id C1F9BFD0AD; Sat, 13 Aug 2016 16:39:29 +0200 (CEST) Received: from mail.brnrd.eu (unknown [193.164.217.85]) by smtp02.qsp.nl (Postfix) with ESMTP; Sat, 13 Aug 2016 16:39:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=brnrd.eu; h=date:from:to:subject:message-id; s=default; bh=wvXrNZ1mVSbZWzYRse8SY65FZuqwcE1OM0p9HHV2EuA=; b=aiSKXtbsbkW4SytVt2ismCmkxAXQuFNHGpvNb71NhUGQyMC1TE3Zw/cbq5AHduldn+rhVSkuFROS1epVzEiPv4qx3KtxsNZ0k6FMdf2kBDTORvMNxv5vX7eAk8YgaN86z1PDAAPtsdzTmicLeWOwPjEg+isaz7bpZVljM8wLpEyGhj40NphLVFCkO659Ovmj5QIrAJhbS7BVgEJTs+0Zkanz8iYr7rmtiYzQiTI02Bw6cMaOEtZI7IMax5sgmnDptat9NCQHjfUQLChFT3Dcx/pPkU+SUcW/RW8xj6z9LSEzD5sHAxByK99DOGEvEJ7AimhTvLoEHo3EzQKxX/88iw== Received: by bachfreund.nl (OpenSMTPD) with ESMTPSA id f45832eb TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Sat, 13 Aug 2016 16:39:29 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 13 Aug 2016 16:39:28 +0200 From: Bernard Spil To: Adam Weinberger Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420150 - in head/security/letskencrypt: . files In-Reply-To: References: <201608122317.u7CNHx6M069763@repo.freebsd.org> Message-ID: X-Sender: brnrd@FreeBSD.org User-Agent: Roundcube Webmail/1.2.0 X-Virus-Scanned: clamav at smtp02 X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HK_RANDOM_ENVFROM,HK_RANDOM_FROM,UNPARSEABLE_RELAY autolearn=disabled version=3.4.1 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on svfilter04.qsp.nl X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Aug 2016 14:39:39 -0000 On 2016-08-13 16:20, Adam Weinberger wrote: >> On 12 Aug, 2016, at 17:17, Bernard Spil wrote: >> >> Author: brnrd >> Date: Fri Aug 12 23:17:58 2016 >> New Revision: 420150 >> URL: https://svnweb.freebsd.org/changeset/ports/420150 >> >> Log: >> security/letskencrypt: Allow configurable license agreement >> >> - Backport upstream fixes for -a option (license agreement URL) >> - Bump PORTREVISION > > Hi Bernard, > > I'm confused about what I'm supposed to do here. > > It looks like the new license URL was added as default: > >> Added: head/security/letskencrypt/files/patch-main.c >> ============================================================================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/security/letskencrypt/files/patch-main.c Fri Aug 12 23:17:58 >> 2016 (r420150) >> @@ -0,0 +1,55 @@ >> + >> ++#define AGREEMENT "https://letsencrypt.org" \ >> ++ "/documents/LE-SA-v1.1.1-August-1-2016.pdf" > > ... but the pkg-message change says that I have to add arguments to > the invocation: > >> Modified: head/security/letskencrypt/files/pkg-message.in >> ============================================================================== >> --- head/security/letskencrypt/files/pkg-message.in Fri Aug 12 >> 23:02:52 2016 (r420149) >> +++ head/security/letskencrypt/files/pkg-message.in Fri Aug 12 >> 23:17:58 2016 (r420150) >> @@ -1,4 +1,15 @@ >> >> +LetsEncrypt's ACME servers have changed the LE license >> +agreement. To successfully run renewal you have to add >> + >> + -a https://letsencrypt.org/documents/LE-SA-v1.1.1-August-1-2016.pdf >> + >> +to the command invocation. > > The files/letskencrypt.sh.in doesn't contain that argument. > > So is it set automatically? Do I need to alter my letskencrypt.sh, or > is the pkg-message inaccurate? > > # Adam Hi Adam, Correct, that pkg-message update is not required. I've held back on committing not to have unneccessary commits. After updating this just runs without supplying -a. The new -a parameter has been added to facilitate future changes in the license agreement. Additionally, this is only required when you create a new account key. Any subsequent requests with the original account key do NOT need this license agreement update. Cheers, Bernard.