From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jan 14 03:00:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CA71BD7E for ; Mon, 14 Jan 2013 03:00:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id AF8EFE0E for ; Mon, 14 Jan 2013 03:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r0E300ik092306 for ; Mon, 14 Jan 2013 03:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r0E300X8092303; Mon, 14 Jan 2013 03:00:00 GMT (envelope-from gnats) Resent-Date: Mon, 14 Jan 2013 03:00:00 GMT Resent-Message-Id: <201301140300.r0E300X8092303@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, John Hein Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 25A2CCED; Mon, 14 Jan 2013 02:54:34 +0000 (UTC) (envelope-from jhein@symmetricom.com) Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214]) by mx1.freebsd.org (Postfix) with ESMTP id D8E0CDE1; Mon, 14 Jan 2013 02:54:33 +0000 (UTC) Received: from gromit.timing.com (gromit.timing.com [206.168.13.209]) by duck.symmetricom.us (8.14.5/8.14.5) with ESMTP id r0E2rqDI088080; Sun, 13 Jan 2013 19:54:04 -0700 (MST) (envelope-from jhein@symmetricom.com) Received: from gromit.timing.com (localhost [127.0.0.1]) by gromit.timing.com (8.14.5/8.14.5) with ESMTP id r0E2rf3r076795; Sun, 13 Jan 2013 19:53:42 -0700 (MST) (envelope-from jhein@gromit.timing.com) Received: (from jhein@localhost) by gromit.timing.com (8.14.5/8.14.5/Submit) id r0E2rVv9076794; Sun, 13 Jan 2013 19:53:31 -0700 (MST) (envelope-from jhein) Message-Id: <201301140253.r0E2rVv9076794@gromit.timing.com> Date: Sun, 13 Jan 2013 19:53:31 -0700 (MST) From: John Hein To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/175276: [patch] devel/py-gobject OPTIONSFILE eval order problem Cc: mezz@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: John Hein List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2013 03:00:00 -0000 >Number: 175276 >Category: ports >Synopsis: [patch] devel/py-gobject OPTIONSFILE eval order problem >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jan 14 03:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: John Hein >Release: >Organization: >Environment: >Description: devel/py-gobject looks for options settings in one filename and then generates an options file of a different name. That is, su -c 'make config' will allow the user to create an options file, but that file is not the one included by bsd.options.mk There is a fundamental evaluation order issue with OPTIONSFILE and UNIQUENAME when using knobs that affect UNIQUENAME such as PKGNAMEPREFIX. In this case, it causes bsd.options.mk to look for gobject/options, but py-gobject/options to be generated (by do-config in bsd.port.mk). % cd devel/py-gobject % make -V PORTNAME -dd | & grep /options; echo ===; make -V PORTNAME -V OPTIONSFILE Searching for /var/db/ports/gobject/options...Looking for "/var/db/ports/gobject/options"...failed. Returning NULL Searching for /var/db/ports/gobject/options.local...Looking for "/var/db/ports/gobject/options.local"...failed. Returning NULL Searching for /var/db/ports/py27-gobject/options...Looking for "/var/db/ports/py27-gobject/options"...failed. Returning NULL === gobject /var/db/ports/py27-gobject/options This started happening with r309649 (OPTIONSng conversion) on 2012-12-29. But even if that is solved (so PKGNAMEPREFIX is not ignored in the first evaluation of OPTIONSFILE), I think we still want to override the OPTIONSFILE value to remove the python version (e.g., py-gobject/options, not py27-gobject/options). So we want to override the default OPTIONSFILE here. See attached patch which solves both the eval order issue and the removal of in py-gobject. >How-To-Repeat: >Fix: Index: Makefile =================================================================== --- Makefile (revision 310148) +++ Makefile (working copy) @@ -35,6 +35,7 @@ CONFLICTS= py*-gtk-0* PLIST_SUB= PYTHON_VER="${PYTHON_VER}" +OPTIONSFILE= ${PORT_DBDIR}/py-${PORTNAME}/options OPTIONS_DEFINE= LIBFFI LIBFFI_DESC= Enable libffi support >Release-Note: >Audit-Trail: >Unformatted: