Date: Fri, 29 Aug 2008 05:39:59 -0400 From: Randall Stewart <rrs@lakerest.net> To: Giorgos Keramidas <keramida@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet sctp_timer.c sctp_timer.h Message-ID: <77C320B0-5288-497A-B893-7F2D20F7B8A2@lakerest.net> In-Reply-To: <87tzd4n6z8.fsf@kobe.laptop> References: <200808282031.m7SKVUdD076580@repoman.freebsd.org> <87tzd4n6z8.fsf@kobe.laptop>
next in thread | previous in thread | raw e-mail | index | archive | help
MY bad for not catching it earlier.. I forgot to build LINT (which I usually do) especially when I am fixing something for a outside user (they were having panics and I realized all panics that are recoverable SHOULD be under INVARANTS, panic I think was caused by another change I put in strict_sacks really needs to be on by default and only turned off at interops...) R On Aug 28, 2008, at 5:51 PM, Giorgos Keramidas wrote: > On Thu, 28 Aug 2008 20:31:24 +0000 (UTC), Randall Stewart <rrs@freebsd.org > > wrote: >> rrs 2008-08-28 20:31:24 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/netinet sctp_timer.c sctp_timer.h >> Log: >> SVN rev 182405 on 2008-08-28 20:31:24Z by rrs >> >> ok, non static the function and put in the .h so >> when we do INVARANT compile the compiler will not >> dis the function that is not used. Hmm maybe I should have >> made it ifndef INVARIANTs.. > > gcc should be smart enough to throw away the non-static function > if SCTP is built into the kernel (and not as a module) *and* > there are no external references from other parts of the source. > So this should work fine. > > The ifndef INVARIANTS version is probably something like the > second patch I sent earlier, also at > http://people.freebsd.org/~keramida/diff/sctp-timer-20080828-02.patch > > but I didn't really 'like' having a static function inside a > large #ifndef INVARIANTS block... > > Thanks for fixing this so fast :-) > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?77C320B0-5288-497A-B893-7F2D20F7B8A2>