From owner-svn-src-all@FreeBSD.ORG  Tue Dec 28 13:29:44 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DD5E5106564A;
	Tue, 28 Dec 2010 13:29:44 +0000 (UTC)
	(envelope-from uqs@spoerlein.net)
Received: from acme.spoerlein.net (acme.spoerlein.net
	[IPv6:2a01:4f8:131:23c2::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 68A888FC15;
	Tue, 28 Dec 2010 13:29:44 +0000 (UTC)
Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1])
	by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id oBSDThPm010173
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 28 Dec 2010 14:29:43 +0100 (CET)
	(envelope-from uqs@spoerlein.net)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net;
	s=dkim200908; t=1293542983;
	bh=jLbaC1iyJW7aN95eaAumLV7pAIYzcw9a/nPEzuq/Ne8=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	Content-Type:In-Reply-To;
	b=HAoe72ZILuVHtEres0QhRlfKTGRWeQ7KrqgnGcwZYBH750zHAkchduLwFoOUd9fUf
	iZfxHNJ45U+NpDiVdX0DTgGIG8MdeM/w1iiEHmOc2mE9+c9q7Nj52a88mW609oLShF
	dpTqMDV8DcNsIZf3RUbEoWHGTiWAhQwHcUoFnHIk=
Date: Tue, 28 Dec 2010 14:29:43 +0100
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net>
To: Konstantin Belousov <kib@FreeBSD.org>
Message-ID: <20101228132942.GY23098@acme.spoerlein.net>
Mail-Followup-To: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net>,
	Konstantin Belousov <kib@FreeBSD.org>, src-committers@FreeBSD.org,
	svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org
References: <201012250842.oBP8gchA016800@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201012250842.oBP8gchA016800@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r216694 - head/libexec/rtld-elf
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Dec 2010 13:29:45 -0000

On Sat, 25.12.2010 at 08:42:38 +0000, Konstantin Belousov wrote:
> Author: kib
> Date: Sat Dec 25 08:42:38 2010
> New Revision: 216694
> URL: http://svn.freebsd.org/changeset/base/216694
> 
> Log:
>   Add a hook to pass debug flags to the build of rtld when doing make in
>   the rtld directory.
>   
>   Reviewed by:	kan

Please revert this, $(VAR) is against style, and passing DEBUG_FLAGS is
the canonical way to achieve what you wanted, eg. make DEBUG_FLAGS=-g is
working just fine for me.

> Modified:
>   head/libexec/rtld-elf/Makefile
> 
> Modified: head/libexec/rtld-elf/Makefile
> ==============================================================================
> --- head/libexec/rtld-elf/Makefile	Fri Dec 24 21:31:18 2010	(r216693)
> +++ head/libexec/rtld-elf/Makefile	Sat Dec 25 08:42:38 2010	(r216694)
> @@ -34,7 +34,7 @@ CFLAGS+=	-fPIC
>  .else
>  CFLAGS+=	-fpic
>  .endif
> -CFLAGS+=	-DPIC
> +CFLAGS+=	-DPIC $(DEBUG)
>  LDFLAGS+=	-shared -Wl,-Bsymbolic
>  DPADD=		${LIBC_PIC}
>  LDADD=		-lc_pic -lssp_nonshared