Date: Tue, 23 Mar 2004 19:02:36 +0600 From: Alexey Dokuchaev <danfe@nsu.ru> To: Bill Paul <wpaul@freebsd.org> Cc: Nate Lawson <nate@root.org> Subject: Re: cvs commit: src/sys/amd64/isa atpic.c src/sys/contrib/dev/oltr if_oltr.c src/sys/dev/aac aac_pci.c src/sys/dev/acpic Message-ID: <20040323130235.GB39851@regency.nsu.ru> In-Reply-To: <20040322191542.CD8DE16A4CF@hub.freebsd.org> References: <20040322102119.P33645@root.org> <20040322191542.CD8DE16A4CF@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 22, 2004 at 11:15:42AM -0800, Bill Paul wrote:
>
> This is the entire bus_alloc_resource_any() function:
>
> static __inline struct resource *
> bus_alloc_resource_any(device_t dev, int type, int *rid, u_int flags)
> {
> return (bus_alloc_resource(dev, type, rid, 0ul, ~0ul, 1, flags));
> }
>
> Please to be explaining why this isn't a macro:
>
> #define bus_alloc_resource_any(dev, type, rid, flags) \
> bus_alloc_resource(dev, type, rid, 0ul, ~0ul, 1, flags)
Pardon my sneaking in discussion, but I also wonder why isn't this a
macro? I probably should blame myself for not looking at the actual
diff when I received your commit message, but I was pretty sure that
you've just added a macro like Bill suggested above.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040323130235.GB39851>