From owner-freebsd-hackers@FreeBSD.ORG Fri Nov 14 03:49:44 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0B9C8D92; Fri, 14 Nov 2014 03:49:44 +0000 (UTC) Received: from st11p02mm-asmtp001.mac.com (st11p02mm-asmtpout001.mac.com [17.172.220.236]) (using TLSv1 with cipher DES-CBC3-SHA (112/168 bits)) (Client CN "smtp.me.com", Issuer "VeriSign Class 3 Extended Validation SSL SGC CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D2EEB616; Fri, 14 Nov 2014 03:49:43 +0000 (UTC) Received: from fukuyama.hsd1.ca.comcast.net (unknown [73.162.13.215]) by st11p02mm-asmtp001.mac.com (Oracle Communications Messaging Server 7u4-27.10(7.0.4.27.9) 64bit (built Jun 6 2014)) with ESMTPSA id <0NF000FP9FYFBW20@st11p02mm-asmtp001.mac.com>; Fri, 14 Nov 2014 03:49:30 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.28,0.0.0000 definitions=2014-11-14_01:2014-11-14,2014-11-13,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1408290000 definitions=main-1411140032 Content-type: text/plain; charset=us-ascii MIME-version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) Subject: Re: DTrace: stack() does not print kernel module functions for i386 From: Rui Paulo In-reply-to: <201411131336.12334.jhb@freebsd.org> Date: Thu, 13 Nov 2014 19:49:27 -0800 Content-transfer-encoding: quoted-printable Message-id: References: <20141109093632.GV53947@kib.kiev.ua> <9011F920-3092-4E61-9CDC-68FD9092BB7D@me.com> <201411131336.12334.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1990.1) Cc: Konstantin Belousov , freebsd-hackers@freebsd.org, freebsd-dtrace@freebsd.org, Shrikanth Kamath , avg@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2014 03:49:44 -0000 On Nov 13, 2014, at 10:36, John Baldwin wrote: > Why have the #ifdef? In theory other platforms besides amd64 could = use > sys/kern/link_elf_obj.c. It doesn't hurt to just let the code always = accept > both ET_DYN and ET_REL does it? No, it doesn't hurt. -- Rui Paulo