Date: Wed, 29 Dec 2010 03:44:33 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: "freebsd-rc@FreeBSD.org" <freebsd-rc@freebsd.org>, "ggg_mail@inbox.ru" <ggg_mail@inbox.ru> Subject: Re: conf/153460: devd(8) cannot be restarted correctly via /etc/rc.d script Message-ID: <AANLkTinRSC_pBVdK_m8Hrk=_32mjMZDSc77__5iUyV_Z@mail.gmail.com> In-Reply-To: <4D1A3DFE.8090009@FreeBSD.org> References: <201012272253.oBRMrH7k025331@freefall.freebsd.org> <1232C1B4-DA64-4332-906E-288B8C1E39FE@gmail.com> <4D1A3DFE.8090009@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yeah, and while I do agree there are some issues with the change. For starters, devd.conf does also have a pid-file directive so the .conf file and the rc script can get out of sync: http://www.freebsd.org/cgi/man.cgi?query=devd.conf&sektion=5&apropos=0&manpath=FreeBSD+8.1-RELEASE . There was also an issue with devd that needs to be resolved so that file descriptors are closed properly. That is most likely the root cause of the issue that the OP is seeing: http://unix.derkeiler.com/Mailing-Lists/FreeBSD/current/2010-06/msg00811.html . Warner MFCed the change a while back IIRC, but it's still worth checking. So this might address one other part of the bug (the rc-script part), but unfortunately the pidfile variable needs to be massaged according to the devd.conf file; thankfully that's static as there isn't a devd_flags or devd_args variable :). Thanks for the followup! -Garrett On Tue, Dec 28, 2010 at 11:43 AM, Doug Barton <dougb@freebsd.org> wrote: > Did you actually read the PR, or my change? > > On 12/28/2010 02:09, Garrett Cooper wrote: >> >> Uh, pretty sure it was a devd bug that was fixed on current several months >> back by imp that I originally reported on current@. The reporter should >> check and see if devd updated to stable-8 solves the reported issue. fstat >> output on the pidfile would help too. >> -Garrett >> >> Sent from my iPhone >> >> On Dec 27, 2010, at 10:53 PM, dougb@FreeBSD.org wrote: >> >>> Synopsis: devd(8) cannot be restarted correctly via /etc/rc.d script >>> >>> State-Changed-From-To: open->patched >>> State-Changed-By: dougb >>> State-Changed-When: Mon Dec 27 22:50:32 UTC 2010 >>> State-Changed-Why: >>> >>> Patched in r216744 >>> >>> >>> Responsible-Changed-From-To: freebsd-rc->dougb >>> Responsible-Changed-By: dougb >>> Responsible-Changed-When: Mon Dec 27 22:50:32 UTC 2010 >>> Responsible-Changed-Why: >>> >>> I did the change, I'll handled the MFC
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinRSC_pBVdK_m8Hrk=_32mjMZDSc77__5iUyV_Z>