From owner-freebsd-ports@FreeBSD.ORG Wed Aug 26 18:47:51 2009 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CBF9C106568E; Wed, 26 Aug 2009 18:47:51 +0000 (UTC) (envelope-from oberman@es.net) Received: from mailgw.es.net (mail4.es.net [IPv6:2001:400:6000:6::2]) by mx1.freebsd.org (Postfix) with ESMTP id 7CF208FC22; Wed, 26 Aug 2009 18:47:51 +0000 (UTC) Received: from ptavv.es.net (ptavv.es.net [IPv6:2001:400:910::29]) by mailgw.es.net (8.14.3/8.14.3) with ESMTP id n7QIlmCn024757 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 26 Aug 2009 11:47:49 -0700 Received: from ptavv.es.net (ptavv.es.net [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id 4E77A1CC09; Wed, 26 Aug 2009 11:47:48 -0700 (PDT) To: Matthew Seaman In-reply-to: Your message of "Wed, 26 Aug 2009 07:05:12 BST." <4A94D098.2040501@infracaninophile.co.uk> Date: Wed, 26 Aug 2009 11:47:48 -0700 From: "Kevin Oberman" Message-Id: <20090826184748.4E77A1CC09@ptavv.es.net> X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5, 1.2.40, 4.0.166 definitions=2009-08-26_08:2009-08-11, 2009-08-26, 2009-08-26 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=5.0.0-0907200000 definitions=main-0908260141 Cc: ports@freebsd.org, Peter Pentchev , ahze@freebsd.org Subject: Re: serpentine port forces dependency on muine X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2009 18:47:51 -0000 > Date: Wed, 26 Aug 2009 07:05:12 +0100 > From: Matthew Seaman > > Kevin Oberman wrote: > > > If muine found in /usr/local/bin/, it will be built with the plug-in, > > regardless of which way the MUINE configure option is set because: > > .if (defined(MUINE) || exists(${LOCALBASE}/bin/muine)) && ${ARCH}=="i386" > > This is incorrect behaviour in any case: ports should not arbitrarily change configuration depending on what is or is not already installed, and user > choices from OPTIONS dialogues should be paramount. The test should be: > > .if defined(WITH_MUINE) && !defined(WITHOUT_MUINE) && ${ARCH} =="i386" The more I look at this port, the stranger it is. It has OPTIONS=, but does not include bsd.port.options.mk. It then uses tests on a variable named MUINE (same as the option), not WITH_MUINE or WITHOUT_MUINE. This effectively makes the "option" not an option, at all. Serpentine is ALWAYS built with the muine plug-in and, since the muine port is broken (probably forever), this effectively breaks serpentine. I am baffled as to how this came to pass. The maintainer (ahze) knows a lot more about FreeBSD porting than I do, so I have to believe that there is some sense behind this, but I don't see it. As serpentine is a part of the gnome2-power-tools metaport and a LOT of folks are likely to be re-building a lot of ports due to the V8.0 release, I'd really like to see it fixed. This does not effect me any longer as I have commented out the part of the configuration that enables the muine plug-in, rebuilt serpentine, and deinstalled muine, but I am sure it will cause problems for others. -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634 Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751