From owner-svn-src-head@freebsd.org Fri Oct 23 21:56:15 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7E113A1C99B for ; Fri, 23 Oct 2015 21:56:15 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5072C6A0 for ; Fri, 23 Oct 2015 21:56:15 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Fri, 23 Oct 2015 21:56:29 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t9NLuC4o021911; Fri, 23 Oct 2015 15:56:12 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1445637372.91534.38.camel@freebsd.org> Subject: Re: svn commit: r289773 - in head: sbin/sysctl sys/kern sys/sys From: Ian Lepore To: cem@FreeBSD.org, Mark Linimon Cc: NGie Cooper , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Date: Fri, 23 Oct 2015 15:56:12 -0600 In-Reply-To: References: <201510222303.t9MN37D2093845@repo.freebsd.org> <20151023210604.GA12348@lonesome.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 21:56:15 -0000 On Fri, 2015-10-23 at 14:43 -0700, Conrad Meyer wrote: > On Fri, Oct 23, 2015 at 2:06 PM, Mark Linimon > wrote: > > On Fri, Oct 23, 2015 at 08:09:35AM -0700, Conrad Meyer wrote: > > > What is __FreeBSD_version and why would it be bumped? > > > > > > > > This variable exists to tell the Ports Collection, among others, > > that "something has changed that may require you to patch and/or > > recompile." > > Ok. Nothing has changed that may require ports to patch and/or > recompile, so I don't think this needs to be bumped. > > Best, > Conrad > "ports need recompile" is only one of several reasons to bump the version. Another is making it possible to test for new features that arrived with a given version, and that's what you've done. Suppose I maintain an out-of-tree driver that has to build on several versions, and uint16 is really the right type for its sysctl but it also has to work on versions that don't have that support. That tends to get handled with things like #if __FreeBSD_version < NNNNNNNN. (Contrived example here maybe, since if uint32 worked on one version, I'd likely use it on all of versions.) One of the implications of the feature-availability testing is that when you MFC your change, you also have to bump the version number on that branch (independently, not via MFC). -- Ian