Date: Wed, 13 Feb 2013 18:18:58 GMT From: Brooks Davis <brooks@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 222009 for review Message-ID: <201302131818.r1DIIwOS073465@skunkworks.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@222009?ac=10 Change 222009 by brooks@brooks_zenith on 2013/02/13 18:18:29 Stop disabling interupts over writes. The spec does not require it, things appear to work fine without it, and it's insanely slow to disable and reeneable for every word written. Affected files ... .. //depot/projects/ctsrd/beribsd/src/sys/dev/cfi/cfi_core.c#7 edit Differences ... ==== //depot/projects/ctsrd/beribsd/src/sys/dev/cfi/cfi_core.c#7 (text+ko) ==== @@ -393,7 +393,6 @@ uint16_t *x16; uint32_t *x32; } ptr, cpyprt; - register_t intr; int error, i, neederase = 0; uint32_t st; u_int wlen; @@ -510,13 +509,6 @@ } } - /* - * Make sure the command to start a write and the - * actual write happens back-to-back without any - * excessive delays. - */ - intr = intr_disable(); - switch (sc->sc_cmdset) { case CFI_VEND_INTEL_ECS: case CFI_VEND_INTEL_SCS: @@ -542,8 +534,6 @@ break; } - intr_restore(intr); - error = cfi_wait_ready(sc, sc->sc_wrofs, sc->sc_write_timeout); if (error) goto out;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302131818.r1DIIwOS073465>