From owner-p4-projects@FreeBSD.ORG  Wed Feb 13 18:18:59 2013
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
 id 0C49EE13; Wed, 13 Feb 2013 18:18:59 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id C55DCE11
 for <perforce@freebsd.org>; Wed, 13 Feb 2013 18:18:58 +0000 (UTC)
 (envelope-from brooks@freebsd.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
 [IPv6:2001:1900:2254:2068::682:0])
 by mx1.freebsd.org (Postfix) with ESMTP id B68E8728
 for <perforce@freebsd.org>; Wed, 13 Feb 2013 18:18:58 +0000 (UTC)
Received: from skunkworks.freebsd.org ([127.0.1.74])
 by skunkworks.freebsd.org (8.14.6/8.14.6) with ESMTP id r1DIIwFG073468
 for <perforce@freebsd.org>; Wed, 13 Feb 2013 18:18:58 GMT
 (envelope-from brooks@freebsd.org)
Received: (from perforce@localhost)
 by skunkworks.freebsd.org (8.14.6/8.14.6/Submit) id r1DIIwOS073465
 for perforce@freebsd.org; Wed, 13 Feb 2013 18:18:58 GMT
 (envelope-from brooks@freebsd.org)
Date: Wed, 13 Feb 2013 18:18:58 GMT
Message-Id: <201302131818.r1DIIwOS073465@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
 brooks@freebsd.org using -f
From: Brooks Davis <brooks@FreeBSD.org>
Subject: PERFORCE change 222009 for review
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.14
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2013 18:18:59 -0000

http://p4web.freebsd.org/@@222009?ac=10

Change 222009 by brooks@brooks_zenith on 2013/02/13 18:18:29

	Stop disabling interupts over writes.  The spec does not
	require it, things appear to work fine without it, and it's
	insanely slow to disable and reeneable for every word written.

Affected files ...

.. //depot/projects/ctsrd/beribsd/src/sys/dev/cfi/cfi_core.c#7 edit

Differences ...

==== //depot/projects/ctsrd/beribsd/src/sys/dev/cfi/cfi_core.c#7 (text+ko) ====

@@ -393,7 +393,6 @@
 		uint16_t	*x16;
 		uint32_t	*x32;
 	} ptr, cpyprt;
-	register_t intr;
 	int error, i, neederase = 0;
 	uint32_t st;
 	u_int wlen;
@@ -510,13 +509,6 @@
 			}
 		}
 
-		/*
-		 * Make sure the command to start a write and the
-		 * actual write happens back-to-back without any
-		 * excessive delays.
-		 */
-		intr = intr_disable();
-
 		switch (sc->sc_cmdset) {
 		case CFI_VEND_INTEL_ECS:
 		case CFI_VEND_INTEL_SCS:
@@ -542,8 +534,6 @@
 			break;
 		}
 
-		intr_restore(intr);
-
 		error = cfi_wait_ready(sc, sc->sc_wrofs, sc->sc_write_timeout);
 		if (error)
 			goto out;