From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Aug 28 14:17:47 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2975F16A4CE
	for <freebsd-ports-bugs@FreeBSD.org>;
	Sat, 28 Aug 2004 14:17:47 +0000 (GMT)
Received: from mail.gmx.net (imap.gmx.net [213.165.64.20])
	by mx1.FreeBSD.org (Postfix) with SMTP id DA27043D54
	for <freebsd-ports-bugs@FreeBSD.org>;
	Sat, 28 Aug 2004 14:17:45 +0000 (GMT)
	(envelope-from h.eichmann@gmx.de)
Received: (qmail 32456 invoked by uid 65534); 28 Aug 2004 14:17:44 -0000
Received: from pD9EC28C0.dip.t-dialin.net (EHLO [192.168.254.42])
	(217.236.40.192)
	by mail.gmx.net (mp026) with SMTP; 28 Aug 2004 16:17:44 +0200
X-Authenticated: #4450881
From: Heiner <h.eichmann@gmx.de>
Organization: ncc-1701
To: freebsd-ports-bugs@FreeBSD.org
Date: Sat, 28 Aug 2004 16:22:07 +0200
User-Agent: KMail/1.6.2
References: <Pine.LNX.4.44.0408280004070.27681-100000@pancho>
In-Reply-To: <Pine.LNX.4.44.0408280004070.27681-100000@pancho>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_PUJMBhpniOGmdRq"
Message-Id: <200408281622.07951.h.eichmann@gmx.de>
cc: linimon@FreeBSD.org
cc: reinhard.lenninger@web.de
Subject: Re: ports/71010: port k3b: detection of TEAC-R56S fails due to
	error in patchfile
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Aug 2004 14:17:47 -0000


--Boundary-00=_PUJMBhpniOGmdRq
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Thanks for the report. A problem with the suggested patch is, that all drives 
named CD-R56Sxxxxx are affected, not only those by TAEC. The attached patch 
should fix this. The reporter should test it, as I do not have a TEAC drive. 
If it works it can be committed.


Heiner


--Boundary-00=_PUJMBhpniOGmdRq
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="patch"

--- files/patch-src-device-k3bdevice.cpp.orig	Tue Jul 20 03:19:58 2004
+++ files/patch-src-device-k3bdevice.cpp	Sat Aug 28 15:57:16 2004
@@ -33,21 +33,21 @@
    cmd[0] = MMC::GET_CONFIGURATION;
    cmd[8] = 8;
    if( cmd.transport( TR_DIR_READ, header, 8 ) ) {
-@@ -769,6 +779,14 @@
-       m_bufferSize = 1024;
-       d->burnfree = false;
-     }
-+    else if( description().startsWith("CD-R56S") ) {
-+      m_writeModes |= TAO;
-+      d->deviceType |= CDROM|CDR;
-+      m_maxWriteSpeed = 6;
-+      m_maxReadSpeed = 24;
-+      m_bufferSize = 1302;
-+      d->burnfree = false;
-+    }
+@@ -752,6 +762,14 @@
+     m_bufferSize = 1024;
+     d->burnfree = false;
    }
-   else if( vendor().startsWith("HP") ) {
-     if( description().startsWith("CD-Writer 6020") ) {
++  else if( vendor().startsWith("TEAC") && description().startsWith("CD-R56S") ) {
++    m_writeModes |= TAO;
++    d->deviceType |= CDROM|CDR;
++    m_maxWriteSpeed = 6;
++    m_maxReadSpeed = 24;
++    m_bufferSize = 1302;
++    d->burnfree = false;
++  }
+   else if( vendor().startsWith("MATSHITA") ) {
+     if( description().startsWith("CD-R   CW-7501") ) {
+       m_writeModes = TAO|SAO;
 @@ -2559,10 +2577,12 @@
  {
    // if the device is already opened we do not close it

--Boundary-00=_PUJMBhpniOGmdRq--