From owner-svn-src-head@freebsd.org Tue Sep 15 04:22:30 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0BC813EF320; Tue, 15 Sep 2020 04:22:30 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Br9796Cvgz4my1; Tue, 15 Sep 2020 04:22:29 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A0008221FD; Tue, 15 Sep 2020 04:22:29 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 08F4MTvW005294; Tue, 15 Sep 2020 04:22:29 GMT (envelope-from bdragon@FreeBSD.org) Received: (from bdragon@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 08F4MTLc005291; Tue, 15 Sep 2020 04:22:29 GMT (envelope-from bdragon@FreeBSD.org) Message-Id: <202009150422.08F4MTLc005291@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: bdragon set sender to bdragon@FreeBSD.org using -f From: Brandon Bergren Date: Tue, 15 Sep 2020 04:22:29 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r365739 - in head: share/man/man5 share/mk stand tools/build/options X-SVN-Group: head X-SVN-Commit-Author: bdragon X-SVN-Commit-Paths: in head: share/man/man5 share/mk stand tools/build/options X-SVN-Commit-Revision: 365739 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Sep 2020 04:22:30 -0000 Author: bdragon Date: Tue Sep 15 04:22:28 2020 New Revision: 365739 URL: https://svnweb.freebsd.org/changeset/base/365739 Log: [PowerPC] Remove obsolete MK_LOADER_FORCE_LE In D12421, the ability to compile stand/ in little-endian was added, with the intention to extend loader.kboot to run in Petitboot. However, no further work was done, as the kernel then gained self-execution capabilities as Petitboot was taught to load FreeBSD kernels directly. The FreeBSD installer on powerpc64 (on POWER8 and POWER9) uses /boot/etc/kboot.conf instead of loader. As this option does nothing but cause stand/ to be miscompiled and actively causes confusion, remove it. (I have a functioning petitboot loader in my local tree, however, it turned out to be quite inconvient to use due to the current petitboot plugin design so I put it on hold.) Reviewed by: emaste, imp, jhibbits Sponsored by: Tag1 Consulting, Inc. Differential Revision: https://reviews.freebsd.org/D26430 Deleted: head/tools/build/options/WITH_LOADER_FORCE_LE Modified: head/share/man/man5/src.conf.5 head/share/mk/src.opts.mk head/stand/defs.mk Modified: head/share/man/man5/src.conf.5 ============================================================================== --- head/share/man/man5/src.conf.5 Tue Sep 15 00:22:30 2020 (r365738) +++ head/share/man/man5/src.conf.5 Tue Sep 15 04:22:28 2020 (r365739) @@ -1,6 +1,6 @@ .\" DO NOT EDIT-- this file is @generated by tools/build/options/makeman. .\" $FreeBSD$ -.Dd September 11, 2020 +.Dd September 14, 2020 .Dt SRC.CONF 5 .Os .Sh NAME @@ -983,9 +983,6 @@ with support for verification based on certificates ob .It Va WITH_LOADER_FIREWIRE Enable firewire support in /boot/loader on x86. This option is a nop on all other platforms. -.It Va WITH_LOADER_FORCE_LE -Set to force the powerpc boot loader to launch the kernel in little -endian mode. .It Va WITHOUT_LOADER_GELI Disable inclusion of GELI crypto support in the boot chain binaries. .Pp Modified: head/share/mk/src.opts.mk ============================================================================== --- head/share/mk/src.opts.mk Tue Sep 15 00:22:30 2020 (r365738) +++ head/share/mk/src.opts.mk Tue Sep 15 04:22:28 2020 (r365739) @@ -211,7 +211,6 @@ __DEFAULT_NO_OPTIONS = \ HESIOD \ LIBSOFT \ LOADER_FIREWIRE \ - LOADER_FORCE_LE \ LOADER_VERBOSE \ LOADER_VERIEXEC_PASS_MANIFEST \ MALLOC_PRODUCTION \ Modified: head/stand/defs.mk ============================================================================== --- head/stand/defs.mk Tue Sep 15 00:22:30 2020 (r365738) +++ head/stand/defs.mk Tue Sep 15 04:22:28 2020 (r365739) @@ -175,12 +175,6 @@ DD=dd ${DD_NOSTATUS} CFLAGS+= -G0 -fno-pic -mno-abicalls .endif -.if ${MK_LOADER_FORCE_LE} != "no" -.if ${MACHINE_ARCH} == "powerpc64" -CFLAGS+= -mlittle-endian -.endif -.endif - # # Have a sensible default #