From owner-svn-src-all@freebsd.org Sat Jan 13 20:06:24 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB3D6E7D360 for ; Sat, 13 Jan 2018 20:06:24 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic315-23.consmr.mail.gq1.yahoo.com (sonic315-23.consmr.mail.gq1.yahoo.com [98.137.65.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A42C2755E4 for ; Sat, 13 Jan 2018 20:06:24 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1515873978; bh=8GtiqrVZjKyskH9EavZFIVGSuFXWoPoH1E3aY/JgTkQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=qMHmTj9K7RA9Apz0gCc9ewQ9OOlSMQdmS3/JNDehn4XSBk0hwAVvgdKECkX1Z3SJwRxKBh115D77Y7D0HdEkHVwCI9wVZpSHu5JZrTmjjQUwVOLONo8sFisuOMim7GjqRNkMe1CzMD/jExlWRSrHSZ+86d02epFNGfLf1busG4OtKnBDTcC9tsZdRWtvhQNz1hqN/Ck9RomAqoMSgxKhGHncwQieNEaaeVuXIP4H8vMX3b9aYaIZY6UEwNBjBEEllZr05Vh0fmN/CU1Q3LbpRqvbY6zc1sy9uQLLfw1vPZSS+B1BpPfhrhK7MBuB3qFpV44U2+D9pDGs0NLo8+BvkQ== X-YMail-OSG: ZzAfhXAVM1lIJDoWIwk2HiHomvzzu2Y6Jnb1aD4cPnP5UGGretgd7P7q1dzPffX imGXKd27mf0OIsnqTv8zUBLX62HdtjQ4VWPu36hNcegWDURjad14lZXnbqPndL0bWZtqyU_DaW4f 3Qq71dPIVFrWj6OXGLBpfSiyDDK3pGYBdg_qk_9WoxeSBMYFmJ2Z43.f9o8XmpksdpslNxvslkBj LBrLBuroPDntP_SsnDu28iK1f8W9tjJoemAcdYd22n2AFvki3A11aSNL.GNxLSW.t71FZwspvvZv YrYgCTVrgqmQ7AiVvlFVlqUv6SbCEMFUgcwtAaQhR_cHz0FkQHl8hcFJdK2eO9xYfauUbk6IKPf8 Pur2P545Kl2Q5wHNdVAn701kPAuZASmQI8fpekdEMqHhrWwH2phEX9h0W8cTgvALFMLU72FViyRE Rvp8ISy1pBN1z.BDG5Xbk_kJzP6kNxKu8R9VWwQxNz1zlNIWDLCsDCw2XXFz768DRoIasLdLK Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Sat, 13 Jan 2018 20:06:18 +0000 Received: from smtp105.rhel.mail.gq1.yahoo.com (EHLO [192.168.0.8]) ([68.180.227.8]) by smtp411.mail.gq1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID 76389664bd9a2b15e2c1394267129846; Sat, 13 Jan 2018 20:06:13 +0000 (UTC) Subject: Re: svn commit: r327940 - head/sys/contrib/zstd/lib/freebsd To: cem@freebsd.org Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801131902.w0DJ2p5m097642@repo.freebsd.org> From: Pedro Giffuni Organization: FreeBSD Project Message-ID: <8b3461ef-0d7d-fc61-5f27-0639301683dd@FreeBSD.org> Date: Sat, 13 Jan 2018 15:06:12 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 20:06:24 -0000 On 13/01/2018 14:59, Conrad Meyer wrote: > On Sat, Jan 13, 2018 at 11:54 AM, Pedro Giffuni wrote: >> On 01/13/18 14:24, Conrad Meyer wrote: >> >> This is not in contrib code -- >> https://lists.freebsd.org/pipermail/svn-src-all/2018-January/156505.html >> . >> Thanks, I read it late... >> >> Shouldn't the local code be in usr.bin/zstd ? > No — this code ports zstd to the kernel. It would not make sense in usr.bin. Bah, yes, it should be somewhere else under sys but then if you use it for ZFS and somewhere else, it's not clear where it should go .. nevermind. I was just backtracing. Please add yourself to the MAINTAINERS file if you want pre-commit reviews. Pedro.