Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Jun 2018 09:45:18 +0000 (UTC)
From:      Eitan Adler <eadler@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r335547 - head/usr.bin/top
Message-ID:  <201806220945.w5M9jI5H044405@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: eadler
Date: Fri Jun 22 09:45:18 2018
New Revision: 335547
URL: https://svnweb.freebsd.org/changeset/base/335547

Log:
  top(1): remove special handling of load > 5
  
  When the load is "high" (an arbitrary value) top(1) previously moved the
  cursor to the top-left of the screen as an acknowledgment. In practice,
  on modern machines, even relatively slow ones, it looked more like a
  glitch. Remove the logic.

Modified:
  head/usr.bin/top/screen.c
  head/usr.bin/top/screen.h
  head/usr.bin/top/top.c

Modified: head/usr.bin/top/screen.c
==============================================================================
--- head/usr.bin/top/screen.c	Fri Jun 22 09:41:13 2018	(r335546)
+++ head/usr.bin/top/screen.c	Fri Jun 22 09:45:18 2018	(r335547)
@@ -55,7 +55,7 @@ static struct termios new_settings;
 static char is_a_terminal = false;
 
 void
-init_termcap(int interactive)
+init_termcap(bool interactive)
 {
     char *bufptr;
     char *PCptr;
@@ -138,7 +138,7 @@ init_termcap(int interactive)
     /* get "ce", clear to end */
     if (!overstrike)
     {
-	clear_line = tgetstr("ce", &bufptr);
+		clear_line = tgetstr("ce", &bufptr);
     }
 
     /* get necessary capabilities */
@@ -312,13 +312,4 @@ clear_eol(int len)
 	}
     }
     return(-1);
-}
-
-void
-go_home(void)
-{
-    if (smart_terminal)
-    {
-	putcap(home);
-    }
 }

Modified: head/usr.bin/top/screen.h
==============================================================================
--- head/usr.bin/top/screen.h	Fri Jun 22 09:41:13 2018	(r335546)
+++ head/usr.bin/top/screen.h	Fri Jun 22 09:45:18 2018	(r335547)
@@ -28,10 +28,9 @@ extern int  screen_width;
 int		clear_eol(int len);
 void	top_standout(const char *msg);
 void	top_clear(void);
-void	go_home(void);
 void	reinit_screen(void);
 void	get_screensize(void);
-void	init_termcap(int interactive);
+void	init_termcap(bool interactive);
 void	end_screen(void);
 void	init_screen(void);
 

Modified: head/usr.bin/top/top.c
==============================================================================
--- head/usr.bin/top/top.c	Fri Jun 22 09:41:13 2018	(r335546)
+++ head/usr.bin/top/top.c	Fri Jun 22 09:45:18 2018	(r335547)
@@ -852,13 +852,6 @@ restart:
 				break;
 
 			    case CMD_update:	/* merely update display */
-				/* is the load average high? */
-				if (system_info.load_avg[0] > LoadMax)
-				{
-				    /* yes, go home for visual feedback */
-				    go_home();
-				    fflush(stdout);
-				}
 				break;
 
 			    case CMD_quit:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806220945.w5M9jI5H044405>