From owner-svn-src-head@freebsd.org Sun Mar 29 02:42:23 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 93B6226FECE; Sun, 29 Mar 2020 02:42:23 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48qfy04nnpz42vy; Sun, 29 Mar 2020 02:42:16 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x533.google.com with SMTP id b1so6848804pgm.8; Sat, 28 Mar 2020 19:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=BjMMGbdycH3RhRQaSyDwxH4l/cXM1VgN4pG+Ep5MjpQ=; b=q5FedAkaYZxEW5DtxkmEpPqaB4o2xUvdVAiv3nXCN+isK+CnZp2o3hVRZpEA46krjr twVTOBuQiilE1WfF5iOkDTkZ/8lbAWAg2Lbugh5/fZH2fVEI9Cz7zvNVX29QjlZwBgV3 zAIhaz0D5ubv74YSk7EZbJ6Ou55tmR5Pkoi4Zp+h62ff5pQnOebOfhsNWVzET3LpVUnX BgKlQrHf+9LBNJDoFPF9Y/+lZRKccfQAQImMD51m7MiGjrEV+GunCxN1XowxKSxdTPQF cy1CY5WQCcxewFW64Rr0/UEytv/CwT/7UJ7R9x0ragkzh2nXyN2dmXOEDtU0e1e3Vn3q vH/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=BjMMGbdycH3RhRQaSyDwxH4l/cXM1VgN4pG+Ep5MjpQ=; b=UedRa858Y9nVbQUua/JUm/8Z8U0HdOx6DuG0RAUH7O/f1WhooSJl3ApzaO1TPdre8J v6iska+g3hgimg3emZDGKo4u09SVyHjLdZASMSfv7kqPOz8h6UAOWU0MLU8SfCY1sOt7 WFQO5JwYlJEH9TPFKdphGBFFzOb4rRbCdofHLk+LBz7Xpmy9C+s+tbB7wAchIl2r2q7T CBv5ozvlqLB5QGSHKCY024GTeTrOhsBBP7vP3ihnDZNiEl6mXvJExXXRH4D1k4KKNnYc +gBNFKG0kauwAL7uHhXpz3rpU0ybhRMDEBgHjrb8p8vJ208YWP3phiuxDdZelw9Zyo41 pZWQ== X-Gm-Message-State: ANhLgQ2zzmeit7tYNbBiMMwmFI8g6rURXFqszbzcDb5eUYQ4T0Io5BKj 2ESlXgFtOHeiCqjLlJDzt1Bh9ut26K0= X-Google-Smtp-Source: ADFU+vveIuU4YBUJxoXAPVn2qeoxRnzvyv201ZrluHtpVrpU8SSuayuxW/rcb2MOCkCLMzmR2TF3Ww== X-Received: by 2002:aa7:91c1:: with SMTP id z1mr6894809pfa.100.1585449726143; Sat, 28 Mar 2020 19:42:06 -0700 (PDT) Received: from [192.168.20.26] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id c11sm7296800pfc.216.2020.03.28.19.42.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Mar 2020 19:42:05 -0700 (PDT) From: Enji Cooper Message-Id: <2A7EAECB-C11A-458C-9495-BC975300D363@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Re: svn commit: r359385 - head/usr.bin/kyua Date: Sat, 28 Mar 2020 19:42:04 -0700 In-Reply-To: Cc: Enji Cooper , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Brooks Davis References: <202003280108.02S18KWc062782@repo.freebsd.org> <20200328032209.GA40889@spindle.one-eyed-alien.net> X-Mailer: Apple Mail (2.3608.60.0.2.5) X-Rspamd-Queue-Id: 48qfy04nnpz42vy X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=q5FedAka; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::533 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-2.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RECEIVED_SPAMHAUS_PBL(0.00)[228.52.19.73.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE(0.00)[ip: (-8.70), ipnet: 2607:f8b0::/32(-0.36), asn: 15169(-0.46), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.3.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Mar 2020 02:42:23 -0000 > On Mar 28, 2020, at 7:37 PM, Enji Cooper = wrote: >=20 >>=20 >> On Mar 27, 2020, at 8:22 PM, Brooks Davis > wrote: >>=20 >> On Sat, Mar 28, 2020 at 01:08:20AM +0000, Enji Cooper wrote: >>> Author: ngie >>> Date: Sat Mar 28 01:08:20 2020 >>> New Revision: 359385 >>> URL: https://svnweb.freebsd.org/changeset/base/359385 = >>>=20 >>> Log: >>> Check in the generated copies of the manpages >>>=20 >>> These manpages were meant to be templated once per `configure` run. >>>=20 >>> Given that we're not bound by as many constants, e.g., `--prefix` = isn't >>> generally changing for kyua in the base system, having to generate = the >>> manpages each build seems slightly less than optimal. >>>=20 >>> In the event that one's build environment doesn't define `$SH`, the = build >>> will also fail until this change is introduced. >>>=20 >>> Instead of jumping through hoops dealing with shells or = permissions, let's >>> just cut to the chase and check the generated copies into the = sourcebase >>> under usr.bin/kyua . >>=20 >> This was the wrong fix. Committing generated manpaged was >> 100% the wrong solution and will make extra work in the >> future. The correct fix is almost certainly the one attached to >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245086 = . If = someone >> doesn't beat me to it I will revert you wrong and broken commit along >> with the followups and commit the correct one (this certainly won't = be >> until at least tomorrow). >=20 > I=E2=80=99ll revert my changes. Done in r359417. Thank you, -Enji=