From owner-freebsd-bugs Thu Jul 23 09:40:36 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA15693 for freebsd-bugs-outgoing; Thu, 23 Jul 1998 09:40:36 -0700 (PDT) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA15675 for ; Thu, 23 Jul 1998 09:40:30 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id JAA01040; Thu, 23 Jul 1998 09:40:01 -0700 (PDT) Received: from david.siemens.de (david.siemens.de [192.35.17.14]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA13603 for ; Thu, 23 Jul 1998 09:31:15 -0700 (PDT) (envelope-from andre.albsmeier@mchp.siemens.de) Received: from mail.siemens.de (salomon.siemens.de [139.23.33.13]) by david.siemens.de (8.9.1/8.9.1) with ESMTP id SAA28120 for ; Thu, 23 Jul 1998 18:29:13 +0200 (MET DST) Received: from curry.mchp.siemens.de (daemon@curry.mchp.siemens.de [146.180.31.23]) by mail.siemens.de (8.9.1/8.9.1) with ESMTP id SAA10749 for ; Thu, 23 Jul 1998 18:30:52 +0200 (MET DST) Received: (from daemon@localhost) by curry.mchp.siemens.de (8.8.8/8.8.8) id SAA14134 for ; Thu, 23 Jul 1998 18:30:53 +0200 (CEST) Message-Id: <199807231630.SAA26689@internal> Date: Thu, 23 Jul 1998 18:30:50 +0200 (CEST) From: Andre Albsmeier To: FreeBSD-gnats-submit@FreeBSD.ORG, jkh@FreeBSD.ORG X-Send-Pr-Version: 3.2 Subject: bin/7381: rshd change breaks environment (fix included) Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org >Number: 7381 >Category: bin >Synopsis: rshd change breaks environment (fix included) >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jul 23 09:40:01 PDT 1998 >Last-Modified: >Originator: Andre Albsmeier >Organization: >Release: FreeBSD 2.2.7-STABLE i386 >Environment: FreeBSD 2.2.7 with rshd.c,v 1.9.2.8 >Description: I use the environment variable REMOTEHOST in tcsh. When doing a 'rsh host command' it was set properly on host. Since jkh's "-Wall cleanup" this behaviour was broken. >How-To-Repeat: Use tcsh on server and client host and do a rsh server 'echo $REMOTEHOST' >Fix: Remove the 'int' before s = rresvport(&lport); *** rshd.c.ORI Thu Jul 23 18:08:48 1998 --- rshd.c Thu Jul 23 18:22:09 1998 *************** *** 304,310 **** (void) alarm(0); if (port != 0) { int lport = IPPORT_RESERVED - 1; ! int s = rresvport(&lport); if (s < 0) { syslog(LOG_ERR, "can't get stderr port: %m"); exit(1); --- 304,310 ---- (void) alarm(0); if (port != 0) { int lport = IPPORT_RESERVED - 1; ! s = rresvport(&lport); if (s < 0) { syslog(LOG_ERR, "can't get stderr port: %m"); exit(1); >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message