Date: Thu, 04 Sep 2008 09:26:02 -0700 From: Sam Leffler <sam@freebsd.org> To: Rafal Jaworowski <raj@semihalf.com> Cc: freebsd-arm@freebsd.org Subject: Re: ARM interrupts fixes Message-ID: <48C00C1A.10503@freebsd.org> In-Reply-To: <48C0092F.3030308@semihalf.com> References: <48BFE533.7010602@semihalf.com> <20080904200232.a8b556c9.stas@FreeBSD.org> <48C0092F.3030308@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Rafal Jaworowski wrote: > Stanislav Sedov wrote: >> The patch looks goot to me. But what about splitting the whitespace >> fixes and the meaningful ones when committing to the tree to not >> pollute the history? > > I can do it, but was under the impression that white space fix-only commits > were rather frowned upon, isn't it the case any longer? Senseless churn is frowned upon. Ya know, the gratuitous knob-polishing some folks like to do that unintentionally introduce subtle bugs because the result isn't tested (and often not found until long after). If you're working in an area and it warrants cleanup then one hopes you're also testing. That's fine but as stas requested please commit the changes separately. Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?48C00C1A.10503>