Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Nov 2001 18:30:52 +0000
From:      Brian Somers <brian@freebsd-services.com>
To:        Akinori MUSHA <knu@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/share/man/man1 builtin.1 src/bin/sh Makefile builtins.def sh.1 src/bin/test test.1 test.c 
Message-ID:  <200111191830.fAJIUqv15801@hak.lan.Awfulhak.org>
In-Reply-To: Message from Akinori MUSHA <knu@FreeBSD.org>  of "Sat, 17 Nov 2001 11:10:11 PST." <200111171910.fAHJABJ92986@freefall.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
> knu         2001/11/17 11:10:11 PST
> =

>   Modified files:
>     share/man/man1       builtin.1 =

>     bin/sh               Makefile builtins.def sh.1 =

>     bin/test             test.1 test.c =

>   Log:
>   Make test(1) a builtin command of our sh(1) for efficiency.  The
>   binary size increase is 3,784 bytes (about 0.6%).
>   =

>   I don't drop the printf builtin while I'm here because some /etc/rc.*=

>   scripts seem to use it before mounting /usr where printf(1) resides.
>   =

>   Reviewed by:    arch (sheldonh)
>   Inspired by:    NetBSD, ksh
>   Clued by:       ume (on how the printf builtin is used)
>   =

>   Revision  Changes    Path
>   1.31      +5 -3      src/bin/sh/Makefile
>   1.8       +2 -1      src/bin/sh/builtins.def
>   1.56      +6 -3      src/bin/sh/sh.1
>   1.17      +9 -1      src/bin/test/test.1
>   1.32      +6 -1      src/bin/test/test.c
>   1.14      +7 -1      src/share/man/man1/builtin.1

This breaks sh:

$ echo "program-not-found; test" | sh

When testcmd() is given an argv[] of { "test", NULL } *and* an error =

has occurred, things go pear shaped.

-- =

Brian <brian@freebsd-services.com>                <brian@Awfulhak.org>
      http://www.freebsd-services.com/        <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour !      <brian@[uk.]OpenBSD.org>



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200111191830.fAJIUqv15801>