Date: Mon, 02 Jul 2018 08:43:38 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: "Jonathan T. Looney" <jtl@freebsd.org> Cc: steven.hartland@multiplay.co.uk, Matt Macy <mmacy@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335856 - in head/sys: netinet sys Message-ID: <201807021543.w62FhcBE060360@slippy.cwsent.com> In-Reply-To: Message from "Jonathan T. Looney" <jtl@freebsd.org> of "Mon, 02 Jul 2018 10:56:10 -0400." <CADrOrmse-LxVcV6oJZErprofTDBxBhPRKxnHm9OOoeGQ0yXHaQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <CADrOrmse-LxVcV6oJZErprofTDBxBhPRKxnHm9OOoeGQ0yXHaQ@mail.gma il.com> , "Jonathan T. Looney" writes: > On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland < > steven.hartland@multiplay.co.uk> wrote: > > > > You have M_WAITOK and a null check in this change > > And, that's the same as the way it was before his commits. So, he did > exactly what he said he was doing and reverted his commits. I don't think > it is good practice to mix reverts with other changes. Yes, mixing reverts with other changes or batching changes together in one commit confuses history. This is my main criticism of Linux commit logs, IMO the worst example of commit log content. There they itemize a shopping list of changes or simply say, pull fixes for X from so-and-so, the patch passes our tests. Five years from now or even a year from now, will anyone remember? > > Since you've noticed this, I think you should feel free to make the change. > > Jonathan -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807021543.w62FhcBE060360>