From owner-svn-src-all@freebsd.org Mon Jul 2 15:43:47 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7575102D5CB; Mon, 2 Jul 2018 15:43:47 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0A5418E2A2; Mon, 2 Jul 2018 15:43:46 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id a0zNfEfslbP3Ia0zPfILG8; Mon, 02 Jul 2018 09:43:45 -0600 X-Authority-Analysis: v=2.3 cv=P64UeBIu c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=R9QF1RCXAYgA:10 a=xfDLHkLGAAAA:8 a=ASrO2z8EAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=1oSP4-2u0spcIPnZQbEA:9 a=CjuIK1q_8ugA:10 a=IfaqVvZgccqrtc8gcwf2:22 a=hMlqHZxbFqNCaWTKXPQf:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id B86332232; Mon, 2 Jul 2018 08:43:40 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w62Fhckf060374; Mon, 2 Jul 2018 08:43:38 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w62FhcBE060360; Mon, 2 Jul 2018 08:43:38 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201807021543.w62FhcBE060360@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Jonathan T. Looney" cc: steven.hartland@multiplay.co.uk, Matt Macy , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335856 - in head/sys: netinet sys In-Reply-To: Message from "Jonathan T. Looney" of "Mon, 02 Jul 2018 10:56:10 -0400." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 02 Jul 2018 08:43:38 -0700 X-CMAE-Envelope: MS4wfP3blfBjuIPFuVfYpjz3z+sp8sIXAukA6L/Rl89XpO1RzL9hDI5xmw7g6CyUjAt7FGOGvRSDwY8kBCBMhjMhHHmxCyuK8kwYnVltPejsNQR3K7eBrckr Ti6dUgoksz5Aphnh8yDHuCZh65TIGrZF7OU2U4/C1rx+MuLiAiTj2QmOSAGA/8bXf2WSa/gEe+B6EtMqt3syv+bsD14Ct4Z3AUPQ2Jy461sNwKXROR+5cv4h bMuEoM0v16UBVJF8F+hGo2+VDmg05ooBf6KlVVhFCNzSpnxfiJnCTnt8DRX2weC+fn6gN3XH88pXXm9WrtBwpG02St6XwQCmVa15hT3S0Y412XaQU+JR692O lyDyeMfhH83MkMIhFTKHvQ0Yx+yDr68awJWciV+am7i05qIgUoBip6O3ukhtobrey3Is/K95 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2018 15:43:47 -0000 In message , "Jonathan T. Looney" writes: > On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland < > steven.hartland@multiplay.co.uk> wrote: > > > > You have M_WAITOK and a null check in this change > > And, that's the same as the way it was before his commits. So, he did > exactly what he said he was doing and reverted his commits. I don't think > it is good practice to mix reverts with other changes. Yes, mixing reverts with other changes or batching changes together in one commit confuses history. This is my main criticism of Linux commit logs, IMO the worst example of commit log content. There they itemize a shopping list of changes or simply say, pull fixes for X from so-and-so, the patch passes our tests. Five years from now or even a year from now, will anyone remember? > > Since you've noticed this, I think you should feel free to make the change. > > Jonathan -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.