Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Nov 2015 16:00:04 -0500
From:      Randall Stewart <rrs@netflix.com>
To:        Bryan Drewery <bdrewery@freebsd.org>
Cc:        "Alexander V. Chernikov" <melifaro@freebsd.org>, Randall Ray Stewart <rrs@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, imp@freebsd.org
Subject:   Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys
Message-ID:  <CCAE1243-3DC1-4077-BC55-AA6EA7750181@netflix.com>
In-Reply-To: <56464CBA.7060206@FreeBSD.org>
References:  <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org> <56464CBA.7060206@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Bryan:

This looks like a decent thing to do..

Still wondering why changing the callout.h header file would not have =
caused
things to recompile to pick up the new argument..

We can do it this way though it looks fine.

You want to commit it or I?

R
On Nov 13, 2015, at 3:48 PM, Bryan Drewery <bdrewery@freebsd.org> wrote:

> On 11/13/2015 12:39 PM, Bryan Drewery wrote:
>> On 11/13/2015 3:16 AM, Alexander V. Chernikov wrote:
>>> 10.11.2015, 17:49, "Randall Stewart" <rrs@FreeBSD.org>:
>>>> Author: rrs
>>>> Date: Tue Nov 10 14:49:32 2015
>>>> New Revision: 290664
>>>> URL: https://svnweb.freebsd.org/changeset/base/290664
>>>>=20
>>>> Log:
>>>>  Add new async_drain to the callout system. This is so-far not used =
but
>>>>  should be used by TCP for sure in its cleanup of the IN-PCB (will =
be coming shortly).
>>>=20
>>> Randall, this commit introduced change in callout_stop() which was =
not mentioned in commit message.
>>> This change has broken lltable arp/nd handling: deleting interface =
address causes immediate panic.
>>> I also see other other code/subsystems relying on callout_stop() =
return value (netgraph, pfsync, iscsi).
>>> I was not able to find any discussion/analysis/testing for these in =
D4076 so this change does not look like being properly tested prior =
commiting..
>>>=20
>>>=20
>>=20
>> Fixing this is pretty easy. Keeping _callout_stop_safe() as a =
function
>> wrapper around a new _callstop_stop_safe_drain() that takes the new
>> argument. Then change callout_stop define to use
>> _callstop_stop_safe_drain(). New code will avoid the wrapper function =
as
>> it is recompiled.
>>=20
>=20
> I was more speaking about hps@ point that the drain ptr is random for
> old modules.
>=20
> This should fix that:
>=20
> https://people.freebsd.org/~bdrewery/patches/callout-abi-compat.diff
>=20
> I don't have any opinion or idea on the return value though. Perhaps a
> revert is best for now until it can be discussed properly.
>=20
> --=20
> Regards,
> Bryan Drewery

--------
Randall Stewart
rrs@netflix.com
803-317-4952








Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CCAE1243-3DC1-4077-BC55-AA6EA7750181>