From owner-svn-src-all@freebsd.org Fri Nov 13 21:00:01 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E62C1A2E928 for ; Fri, 13 Nov 2015 21:00:00 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A5AF51383 for ; Fri, 13 Nov 2015 21:00:00 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by pacdm15 with SMTP id dm15so110498987pac.3 for ; Fri, 13 Nov 2015 13:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=y4LrjwcSkzTb11U8RU8q7DqUy6HXdqZ7H5cIfJRp2fs=; b=iUWXgCV4ULvwFPZE5xLcnmKwvMP0j5LJC3IEEFmQ8hRhSEO8gC8FJ+xoAtPy7/5OxO fI8mOb3D4x2eprHW5mTNVMWE37M7Vb1c1EPkrlIF7iWaTP/sm/K7VKmn7V3T9Ph1Y2+g Vz1B+6EA1pA9/Au5U9TkfVb4W6EeYCMBl3nI0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=y4LrjwcSkzTb11U8RU8q7DqUy6HXdqZ7H5cIfJRp2fs=; b=Lob+VExGXD9W0yhxawMhuJEhta8ZEaek0wHOXt8p6OzL9EGIZKnVM09dl/UwzRZpyM VfgWrGpooomwTkcG1hjRAqFb2LGe/nAiKnc1WJPMpBM5zUwV2n3Zkh0NvCmZZiFjW3i5 JGo+uNcd36fjWKfkQgEvZujcsJZ77+O9V7COv3kwAkEoQ1PS2ATDN0ImhyNkrtB8Q6R0 4lzwoGMBwQnOuTRVhnKAJqA9KCaEn+KeYgB8UqhreBPO1tuFBRNbmdyF3304GirRbmzc H6XK+DW6yzMCbdi8kHZUoK9V/emNEe5wm1PC1gwURf1nyE+qWpn5KYT+mtJ5VUgM9ZkS kF2A== X-Gm-Message-State: ALoCoQlbhadiTKHCOtcktb/jfaP9dn7N08bB6envbgrv382dQZqIPWwogbVxzTLPxZ5Qmc/wgSuv X-Received: by 10.66.90.227 with SMTP id bz3mr35086620pab.36.1447448400262; Fri, 13 Nov 2015 13:00:00 -0800 (PST) Received: from ip-192-168-70-10.us-west-2.compute.internal ([69.53.245.107]) by smtp.gmail.com with ESMTPSA id qk7sm22059504pbb.80.2015.11.13.12.59.57 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Nov 2015 12:59:59 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys From: Randall Stewart In-Reply-To: <56464CBA.7060206@FreeBSD.org> Date: Fri, 13 Nov 2015 16:00:04 -0500 Cc: "Alexander V. Chernikov" , Randall Ray Stewart , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Adrian Chadd , imp@freebsd.org Message-Id: References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org> <56464CBA.7060206@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 21:00:01 -0000 Bryan: This looks like a decent thing to do.. Still wondering why changing the callout.h header file would not have = caused things to recompile to pick up the new argument.. We can do it this way though it looks fine. You want to commit it or I? R On Nov 13, 2015, at 3:48 PM, Bryan Drewery wrote: > On 11/13/2015 12:39 PM, Bryan Drewery wrote: >> On 11/13/2015 3:16 AM, Alexander V. Chernikov wrote: >>> 10.11.2015, 17:49, "Randall Stewart" : >>>> Author: rrs >>>> Date: Tue Nov 10 14:49:32 2015 >>>> New Revision: 290664 >>>> URL: https://svnweb.freebsd.org/changeset/base/290664 >>>>=20 >>>> Log: >>>> Add new async_drain to the callout system. This is so-far not used = but >>>> should be used by TCP for sure in its cleanup of the IN-PCB (will = be coming shortly). >>>=20 >>> Randall, this commit introduced change in callout_stop() which was = not mentioned in commit message. >>> This change has broken lltable arp/nd handling: deleting interface = address causes immediate panic. >>> I also see other other code/subsystems relying on callout_stop() = return value (netgraph, pfsync, iscsi). >>> I was not able to find any discussion/analysis/testing for these in = D4076 so this change does not look like being properly tested prior = commiting.. >>>=20 >>>=20 >>=20 >> Fixing this is pretty easy. Keeping _callout_stop_safe() as a = function >> wrapper around a new _callstop_stop_safe_drain() that takes the new >> argument. Then change callout_stop define to use >> _callstop_stop_safe_drain(). New code will avoid the wrapper function = as >> it is recompiled. >>=20 >=20 > I was more speaking about hps@ point that the drain ptr is random for > old modules. >=20 > This should fix that: >=20 > https://people.freebsd.org/~bdrewery/patches/callout-abi-compat.diff >=20 > I don't have any opinion or idea on the return value though. Perhaps a > revert is best for now until it can be discussed properly. >=20 > --=20 > Regards, > Bryan Drewery -------- Randall Stewart rrs@netflix.com 803-317-4952