Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 02 Dec 2001 16:52:54 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Jesper Skriver <jesper@FreeBSD.org>
Cc:        Josef Karthauser <joe@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Mike Barcroft <mike@FreeBSD.org>
Subject:   Re: cvs commit: CVSROOT cfg.pm log_accum.pl
Message-ID:  <XFMail.011202165254.jhb@FreeBSD.org>
In-Reply-To: <20011202212827.D36916@skriver.dk>

next in thread | previous in thread | raw e-mail | index | archive | help

On 02-Dec-01 Jesper Skriver wrote:
> On Sat, Dec 01, 2001 at 07:55:15PM -0800, John Baldwin wrote:
>> 
>> On 02-Dec-01 Mike Barcroft wrote:
>> > Josef Karthauser <joe@FreeBSD.org> writes:
>> >> joe         2001/12/01 03:38:44 PST
>> >> 
>> >>   Modified files:
>> >>     .                    cfg.pm log_accum.pl 
>> >>   Log:
>> >>   Add the ability to have diffs inserted into the commit email.
>> >>   
>> >>   Submitted by:   jesper
>> >>   
>> >>   Revision  Changes    Path
>> >>   1.44      +5 -2      CVSROOT/cfg.pm
>> >>   1.114     +73 -0     CVSROOT/log_accum.pl
>> > 
>> > cvs-verbose@FreeBSD.org anyone?  This would lower the barrier to entry
>> > for reviewing commits.
>> 
>> Does it limit the length?  p4 submit mails trim the output at 1000 lines. 
>> Otherwise imports of vendor software could be some _very_ large e-mails. :)
> 
> The variable which enable it, it a size limiter, if you set i to 1, the
> diff of a given file will only be shown if it's less than 1 kbyte ...

It doesn't omit the entire diff if it's too long, it makes the diff and then
after the first 1000 lines, it truncates the diff adn prints a "diff truncated
at 1000 lines for mail" line (or something like that.)

Slightly different thing.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011202165254.jhb>