Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Aug 2015 11:12:31 +0200
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        "Philip M. Gollucci" <pgollucci@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r394002 - head/net-p2p/zetacoin
Message-ID:  <119E57656109CE822C0CCF8F@atuin.in.mat.cc>
In-Reply-To: <201508120202.t7C22Fek062663@repo.freebsd.org>
References:  <201508120202.t7C22Fek062663@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--==========CF752A5AE9BA2D883590==========
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline



+--On 12 ao=C3=BBt 2015 02:02:15 +0000 "Philip M. Gollucci"
<pgollucci@FreeBSD.org> wrote:
| Author: pgollucci
| Date: Wed Aug 12 02:02:14 2015
| New Revision: 394002
| URL: https://svnweb.freebsd.org/changeset/ports/394002
|=20
| Log:
|   net-p2p/zetacoin: mark broken on armv6
|  =20
|   Reported by: pkg-fallout
|=20
| Modified:
|   head/net-p2p/zetacoin/Makefile
|=20
| Modified: head/net-p2p/zetacoin/Makefile
| =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
| =3D=3D=3D=3D=3D --- head/net-p2p/zetacoin/Makefile	Wed Aug 12 01:57:53 =
2015
| 	(r394001) +++ head/net-p2p/zetacoin/Makefile	Wed Aug 12 02:02:14 2015
| 	(r394002) @@ -13,6 +13,8 @@ LICENSE=3D	MIT
|  BUILD_DEPENDS=3D	pkg-config:${PORTSDIR}/devel/pkgconf
|  LIB_DEPENDS=3D	libboost_date_time.so:${PORTSDIR}/devel/boost-libs
| =20
| +BROKEN_armv6=3D	#error Please implement AtomicPointer for this platform.

Trying to copy the error message verbatim is nice, but note that # starts a
comment, so:

$ make -V BROKEN_armv6

$

Also, note that setting BROKEN_arch will give the error message:

=3D=3D=3D>  zetacoin-0.9.2.4 is marked as broken on armv6: error Please =
implement
AtomicPointer for this platform.

A simpler and better message would be something like:

BROKEN_armv6=3D   AtomicPointer not implemented.

Documenting the full error message in the commit is nice too.

--=20
Mathieu Arnold
--==========CF752A5AE9BA2D883590==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQJ8BAEBCgBmBQJVyw3/XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I2D8P/i/EE4/Kl+CWAXkssRAwqPES
CRbSpIWFnuMAmHFSdpJqUNBEUfWiQUI5IcqMQ4eGvQb4Fxe8WlwXQVOeqo8bzSC1
AVeVcbqoJ2I2uNbekouLk+++uQOG3dYzmDBnaSrmI+wHKXvPN6IL8yerUlJoQy/4
jGQGHD7OsHgIVNq4Cl3eUI26hqCEf87rqZIFcgj52qm0A6TiVRBR2SwqRmUdh1Vk
uyelfJAZKx8AV04VOuuSy3hU8XqEUV8+T9SdtkRWiQGe+NiNxSwSu1oadQep4mZb
3GIbJP+HQP+xiF22Ffys9ZZPLdLowE7120f0sPY7DEOrPyo9nhQ+mWLuumKgeoXs
3N286SCJr8OYGJ/553Ak8rxz0ozCJ6beHwkUHUITnjYB3uft9LRVwUz62Qc62W71
dbkWszD6Mfgb7L3jPOdsKc2ctnUx/OVQE/GCRoFBNCoVlEv9f/H/A0JmB0l9aZkF
X2WyHnigBq8PetRz6xSphIbJJnW05UsRHSiwyI+GHBYaLzJ2ZJ4cOoxv9NdY9eQT
GGZaqQhpFIZTUrUOZTQJblMuX+YPp09iTALt6Lk9pApNquYBubSOrjUNoE1ynulS
0GMF6HpUgIbM7mGddIKxZ6Ylp2UxAirGYvSiOFtvq8c/Cq0zS5flpBlS+OEVFAwX
NDkg7JXdIRZ8CtnKfCdR
=FCWT
-----END PGP SIGNATURE-----

--==========CF752A5AE9BA2D883590==========--




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?119E57656109CE822C0CCF8F>