From owner-svn-src-all@FreeBSD.ORG Thu Jan 22 23:08:23 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F6E8106564A; Thu, 22 Jan 2009 23:08:23 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk1.360sip.com [72.236.70.240]) by mx1.freebsd.org (Postfix) with ESMTP id E58758FC12; Thu, 22 Jan 2009 23:08:22 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.1.38] (S0106001372fd1e07.vs.shawcable.net [70.71.171.106]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.8) with ESMTP id n0MN8LEm057063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Jan 2009 15:08:22 -0800 (PST) (envelope-from sobomax@FreeBSD.org) Message-ID: <4978FC49.9080806@FreeBSD.org> Date: Thu, 22 Jan 2009 15:07:53 -0800 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: Jung-uk Kim References: <200901221706.n0MH6XN1017768@svn.freebsd.org> <4978D5F9.50506@FreeBSD.org> <200901221536.19137.jkim@FreeBSD.org> In-Reply-To: <200901221536.19137.jkim@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn: head/sys: compat/linprocfs i386/cpufreq X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2009 23:08:23 -0000 Jung-uk Kim wrote: > On Thursday 22 January 2009 03:24 pm, Maxim Sobolev wrote: >> Jung-uk Kim wrote: >>> Author: jkim >>> Date: Thu Jan 22 17:06:33 2009 >>> New Revision: 187594 >>> URL: http://svn.freebsd.org/changeset/base/187594 >>> >>> Log: >>> Replace couple of strcmp(cpu_vendor, "foo") with cpu_vendor_id >>> for i386 >> What about amd64? > > It is #ifdef'ed out in linprocfs.c and smist.c is i386-specific, i.e., > it does not compile on amd64. No, it's not. The function linprocfs_docpuinfo() are the same for both amd64 and i386, so that you've just broken it for amd64 with this commit. -Maxim