From owner-cvs-src@FreeBSD.ORG Mon Apr 18 17:27:55 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F95516A4CE for ; Mon, 18 Apr 2005 17:27:55 +0000 (GMT) Received: from pinus.cc.fer.hr (pinus.cc.fer.hr [161.53.73.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5469343D54 for ; Mon, 18 Apr 2005 17:27:54 +0000 (GMT) (envelope-from ivoras@fer.hr) Received: from [161.53.72.113] (lara.cc.fer.hr [161.53.72.113]) by pinus.cc.fer.hr (8.12.2/8.12.2) with ESMTP id j3IHSPhE012175; Mon, 18 Apr 2005 19:28:30 +0200 (MEST) Message-ID: <4263EDFF.8020005@fer.hr> Date: Mon, 18 Apr 2005 19:27:27 +0200 From: Ivan Voras User-Agent: Mozilla Thunderbird 1.0 (X11/20041213) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Giorgos Keramidas References: <200504161543.j3GFhclO075103@repoman.freebsd.org> <86acnyd2k7.fsf@xps.des.no> <20050418063321.GA85819@dragon.NUXI.org> <42636A16.2070702@elischer.org> <20050418095850.GB12892__4420.21584972299$1113818160$gmane$org@orion.daedalusnetworks.priv> In-Reply-To: <20050418095850.GB12892__4420.21584972299$1113818160$gmane$org@orion.daedalusnetworks.priv> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.bin/top machine.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2005 17:27:55 -0000 Giorgos Keramidas wrote: >>>>>Reduce the width of the THR column to 4 characters, to avoid wrap-around >>>>>of lines in SMP machines (which are wider), until we have a better way >>>>>of handling window sizes & columns in top. >>>> >>>>We should probably drop the CPU column (WCPU should suffice), >>> >>>No, 'CPU' is quite useful on SMP machines. >> >>except for multi threaded apps I'm not an expert, but have you considered this: the "NICE" column seems to be 4 chars wide when it only needs to be 3 (for values +/-20). Sure, "NIC" or "NCE" looks slightly ugly but saves a column :) What about the "PRI" column? Does it serve useful purpose in system diagnostics beyond debugging schedulers? I liked a suggestion someone made, of using "procname/#threads" instead of a separate column (as in "mysqld/30")... it saves at least one character for the column padding :) of course, the "/#threads" part would be removed in "H" mode. Do CPU & WCPU really need to be displayed with precision of two decimal places? Maybe one or no decimal places would be more appropriate, depending on the real or needed precision... What about displaying total number of threads in kernel in the second line of the top status info, something like: "95 processes, 120 threads: 3 running, 117 sleeping, 1 zombie processes" (the "running/sleeping" would then apply to threads, which is probably more appropriate now; threads can't be zombies in themselves, can they?)