From owner-svn-src-head@FreeBSD.ORG Mon Jan 5 17:30:07 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F052A1065672; Mon, 5 Jan 2009 17:30:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id A1CB98FC17; Mon, 5 Jan 2009 17:30:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 0184141C67B; Mon, 5 Jan 2009 18:30:06 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id Jvbyf+LnqPTE; Mon, 5 Jan 2009 18:30:05 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 60D7441C677; Mon, 5 Jan 2009 18:30:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 5C2814448DD; Mon, 5 Jan 2009 17:26:09 +0000 (UTC) Date: Mon, 5 Jan 2009 17:26:09 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Robert Watson In-Reply-To: Message-ID: <20090105172400.T45399@maildrop.int.zabbadoz.net> References: <200901042153.n04LrgkD075147@svn.freebsd.org> <20090104220716.GL14235@hoeg.nl> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, Ed Schouten , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186751 - in head/sys: netinet6 netipsec X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2009 17:30:09 -0000 On Sun, 4 Jan 2009, Robert Watson wrote: > > On Sun, 4 Jan 2009, Ed Schouten wrote: > >> * Robert Watson wrote: >>> Unlike with struct protosw, several instances of struct ip6protosw >>> did not use C99-style sparse structure initialization, so remove >>> NULL assignments for now-removed pr_usrreq function pointers. >> >> Maybe we should convert them to use the C99-style initialisation. This >> could prevent similar issues in the future, right? > > I think Bjoern already has a work-in-progress on this one, but yes, that > would be a good idea. I have broken it out from a larger patch; the C99 initializer is here: http://people.freebsd.org/~bz/20090105-02-c99-initializers.diff I case someone can give it a quick glance I'll commit them. /bz -- Bjoern A. Zeeb The greatest risk is not taking one.