From owner-cvs-all@FreeBSD.ORG  Sat Dec 13 18:02:51 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 24C8116A4CF; Sat, 13 Dec 2003 18:02:51 -0800 (PST)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2485143D94; Sat, 13 Dec 2003 18:02:07 -0800 (PST)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.10/8.12.10) with ESMTP id hBE21oUd059722;
	Sat, 13 Dec 2003 21:01:50 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)hBE21o5R059719;
	Sat, 13 Dec 2003 21:01:50 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Date: Sat, 13 Dec 2003 21:01:50 -0500 (EST)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: Brooks Davis <brooks@one-eyed-alien.net>, dds@FreeBSD.org
In-Reply-To: <20031214015044.GA28627@Odin.AC.HMC.Edu>
Message-ID: <Pine.NEB.3.96L.1031213210011.58711D-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src UPDATING
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Dec 2003 02:02:52 -0000


On Sat, 13 Dec 2003, Brooks Davis wrote:

> On Sat, Dec 13, 2003 at 04:42:01PM -0800, Robert Watson wrote:
> > rwatson     2003/12/13 16:42:01 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     .                    UPDATING 
> >   Log:
> >   Comment on initgroups.c:1.8: it can prevent users from logging in if
> >   a user has over 16 groups defined.
> >   
> >   Reported by:    "Klaus-J. Wolf" <yanestra@web.de>
> 
> A similar change is needed in 4.x or the change should be backed there. 
> I think we should back it out (in stable) until the various users of
> initgroups are fixed to output something useful and, preferably, not
> exit when this happens.  As it is, we turned an rarely hit edge case
> that was somewhat difficult to debug into a fatal error that that is
> about equally difficult to debug and breaks the account in question. 

Sigh.  I agree.  I didn't realize the MFC had happened, but sure enough,
it's change 1.3.8.2.  I have somewhat mixed feelings: I feel strongly we
should generate an error and fail closed, but I also agree that the
transition period was too short (we should have a warning period on the
-STABLE branch), and that we need to do something about error handling.
I'm surprised more people haven't bumped into it, but I guess the MFC was
only a couple of days ago.

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Senior Research Scientist, McAfee Research