Date: Thu, 29 Nov 2018 09:25:30 -0700 From: Warner Losh <imp@bsdimp.com> To: Eugene Grosbein <eugen@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341232 - in head/usr.bin: . trim Message-ID: <CANCZdfoUaqi1-HHvUNQxL95hb1yD8=-qMW8kN5fb%2BYH502GxrA@mail.gmail.com> In-Reply-To: <201811291421.wATELQbx059318@repo.freebsd.org> References: <201811291421.wATELQbx059318@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 29, 2018 at 7:21 AM Eugene Grosbein <eugen@freebsd.org> wrote: > Author: eugen > Date: Thu Nov 29 14:21:26 2018 > New Revision: 341232 > URL: https://svnweb.freebsd.org/changeset/base/341232 > > Log: > Add new small tool trim(1) to delete contents for blocks on flash > based storage devices that use wear-leveling algorithms. > > Reviewed by: hackers@ > I gave only my preliminary comments there. There were many other things that I'd planned on commenting on once this hit Phabricator. Since there were no revised version posted, it was hard to do a line-by-line review. It was at most commented upon by hackers@. The discussion for a name was good there, but since the code wasn't ever posted there (just a pointer to it), it was hard to do a real review. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoUaqi1-HHvUNQxL95hb1yD8=-qMW8kN5fb%2BYH502GxrA>