Date: Tue, 29 Jan 2019 11:36:37 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: "O. Hartmann" <o.hartmann@walstatt.org>, freebsd-current <freebsd-current@freebsd.org>, jail@freebsd.org Subject: Re: icmp (IPv4) issues with VIMAGE JAILs and IPv6 Message-ID: <8a6f74b5-f943-29de-2d65-88cf4e11e147@yandex.ru> In-Reply-To: <20190128134356.23a41e81@freyja> References: <20190128134356.23a41e81@freyja>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--oG9DwHI96HJVc3EWs1S0m14iP8CAgXKwv
Content-Type: multipart/mixed; boundary="qcmeqsMmpMCSAH3DW6KOOmKZg0md7K5Np";
protected-headers="v1"
From: "Andrey V. Elsukov" <bu7cher@yandex.ru>
To: "O. Hartmann" <o.hartmann@walstatt.org>,
freebsd-current <freebsd-current@freebsd.org>, jail@freebsd.org
Message-ID: <8a6f74b5-f943-29de-2d65-88cf4e11e147@yandex.ru>
Subject: Re: icmp (IPv4) issues with VIMAGE JAILs and IPv6
References: <20190128134356.23a41e81@freyja>
In-Reply-To: <20190128134356.23a41e81@freyja>
--qcmeqsMmpMCSAH3DW6KOOmKZg0md7K5Np
Content-Type: multipart/mixed;
boundary="------------C368D5E9F8DD935C73038EA0"
Content-Language: en-US
This is a multi-part message in MIME format.
--------------C368D5E9F8DD935C73038EA0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
On 28.01.2019 15:44, O. Hartmann wrote:
> Stopping all jails, destroying all epairs and bridge0 doesn't change an=
ything.
> The problems occured when IPv6 came into play on the specific host in q=
uestion.
>=20
> Does anyone have any ideas? I'm out of ideas.
Hi,
I think I found the problem, the bug was introduced in r342908.
Can you try attached patch?
--=20
WBR, Andrey V. Elsukov
--------------C368D5E9F8DD935C73038EA0
Content-Type: text/x-patch;
name="ipfw.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="ipfw.diff"
Index: sys/netpfil/ipfw/ip_fw2.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/netpfil/ipfw/ip_fw2.c (revision 343395)
+++ sys/netpfil/ipfw/ip_fw2.c (working copy)
@@ -1410,6 +1410,7 @@ ipfw_chk(struct ip_fw_args *args)
=20
dst_ip.s_addr =3D 0; /* make sure it is initialized */
src_ip.s_addr =3D 0; /* make sure it is initialized */
+ src_port =3D dst_port =3D 0;
pktlen =3D m->m_pkthdr.len;
=20
DYN_INFO_INIT(&dyn_info);
@@ -1688,7 +1689,6 @@ do { \
args->f_id.dst_ip =3D ntohl(dst_ip.s_addr);
} else {
proto =3D 0;
- src_port =3D dst_port =3D 0;
dst_ip.s_addr =3D src_ip.s_addr =3D 0;
=20
args->f_id.addr_type =3D 1; /* XXX */
--------------C368D5E9F8DD935C73038EA0--
--qcmeqsMmpMCSAH3DW6KOOmKZg0md7K5Np--
--oG9DwHI96HJVc3EWs1S0m14iP8CAgXKwv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlxQEJUACgkQAcXqBBDI
oXquvQf/Z8T8yVZmpptZCiATU4QdATmEcu/nyd9AywAEfJ36JORdfr/9KNyoVNvP
3v1GqvyfbMG/gvz2YICXFMGMDIlGj95gizx5jdr+mhNsKCEs4AMZntiPuNRKIc/M
llkcISOR3Y4wTcRBH9gt/T6YT25pywniPSclCyFFPeBnLhyAJwM9nHvhYL8+oRs1
EyHt8jbakAZ3Hx5yKJSkayyHBCaVS3GcXHCkJElPX5Ob9763DQo5OMMoQ3oIjG8s
0K+1GXpTU2gpWeHlKKcBnSN32IQS0mYWZjkFAmX+G+aOj144eMwrRgf87ZebtYex
P32qQIqJXk99LwLxZItRgjpV7npI3A==
=jkPm
-----END PGP SIGNATURE-----
--oG9DwHI96HJVc3EWs1S0m14iP8CAgXKwv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8a6f74b5-f943-29de-2d65-88cf4e11e147>