Date: Sat, 18 Sep 2010 19:00:11 GMT From: Eygene Ryabinkin <rea-fbsd@codelabs.ru> To: freebsd-ports-bugs@FreeBSD.org Subject: ports/150703: maintainer-update of mail/mutt-devel Message-ID: <201009181900.o8IJ0BmD053894@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/150703; it has been noted by GNATS.
From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To: bug-followup@freebsd.org
Cc:
Subject: ports/150703: maintainer-update of mail/mutt-devel
Date: Sat, 18 Sep 2010 22:55:36 +0400
Udo, your mktemp patch is slightly incorrect: since _mutt_mktemp now has
'slen' argument, you should use it instead of _POSIX_PATH_MAX and check
for slen > 6 to avoid signed underflow in snprintf().
And it is better not to drop introduced debug statements: they could
help debugging weird problems.
--
Eygene
_ ___ _.--. #
\`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard
/ ' ` , __.--' # to read the on-line manual
)/' _/ \ `-_, / # while single-stepping the kernel.
`-'" `"\_ ,_.-;_.-\_ ', fsc/as #
_.-'_./ {_.' ; / # -- FreeBSD Developers handbook
{_.-``-' {_/ #
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009181900.o8IJ0BmD053894>