From owner-freebsd-bugs@freebsd.org Wed Apr 12 16:07:03 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB487D3A854 for ; Wed, 12 Apr 2017 16:07:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7B017C37 for ; Wed, 12 Apr 2017 16:07:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v3CG73LQ054928 for ; Wed, 12 Apr 2017 16:07:03 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 218597] [CRYPTODEV] spurious wakeup and synchronisation problem Date: Wed, 12 Apr 2017 16:07:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: alexandre.martins@stormshield.eu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 16:07:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218597 Bug ID: 218597 Summary: [CRYPTODEV] spurious wakeup and synchronisation problem Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: alexandre.martins@stormshield.eu Created attachment 181725 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D181725&action= =3Dedit proposed patch I using a dual core ARMADA 38X platform that contains a CESA module to accelerate cryptography operations. I have some crashes when using the cryptodev through OpenSSL. The crash only happen when the following conditions are met: - Multi-core system is used - Hardware acceleration is used - Hardware acceleration perform an interruption to signal the operations completion That are the scenario, first: - A process ask a cryptographic operation - The crypto operation is send to the CESA - msleep is called, but the process seems to be migrated on another CPU, a= nd msleep return immediately (spurious wakeup) (I puted a KASSERT that check if the CRYPTO_F_DONE is present and it ris= e) - The operation looks like complete and memory is freed - The CESA performs the cryptographic operation on the freed memory that m= ay cause corruption in some other parts of the kernel. Second: - The call to crypto_dispatch is done, but the scheduler prempt the process before the lock on ces->lock is done - The CESA perform the operation and crypto_done is called by the ithread - The flag CRYPTO_F_DONE is put and scheduler preempt the ithread - The user process continue, take the lock and check the flag, that is present, and doesn't call msleep. - It free the memory, and return to the userland - The ithread is resumed and calls the callbacks that crash by accessing t= he freed memory. I attach my proposed patch to fix that issue --=20 You are receiving this mail because: You are the assignee for the bug.=