From owner-cvs-all@FreeBSD.ORG Sat Dec 9 17:57:51 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6AC2D16A412; Sat, 9 Dec 2006 17:57:51 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id A9ECF43CA2; Sat, 9 Dec 2006 17:56:44 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 6ECD7487F7; Sat, 9 Dec 2006 18:57:47 +0100 (CET) Received: from localhost (dlv121.neoplus.adsl.tpnet.pl [83.24.51.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 3E22D487F2; Sat, 9 Dec 2006 18:57:41 +0100 (CET) Date: Sat, 9 Dec 2006 18:57:40 +0100 From: Pawel Jakub Dawidek To: Craig Rodrigues Message-ID: <20061209175740.GB12193@garage.freebsd.pl> References: <200612091627.kB9GRoRU010471@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cmJC7u66zC7hs+87" Content-Disposition: inline In-Reply-To: <200612091627.kB9GRoRU010471@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/unionfs union_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Dec 2006 17:57:51 -0000 --cmJC7u66zC7hs+87 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 09, 2006 at 04:27:50PM +0000, Craig Rodrigues wrote: > rodrigc 2006-12-09 16:27:50 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/fs/unionfs union_subr.c=20 > Log: > In unionfs_hashrem(), use LIST_FOREACH_SAFE when iterating over > the list of nodes to free them. > =20 > CID: 1668 > Found by: Coverity Prevent (tm) What was before is also safe, but coverity prevent often reports it as a bug, which is actually false positive. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --cmJC7u66zC7hs+87 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (FreeBSD) iD8DBQFFevkUForvXbEpPzQRAuEzAKCuvIvcnf4voZ7qMq0CskaD7ZWvFwCguF1S qMmrdtnPy+mFvr+azvsrwTs= =Zt3e -----END PGP SIGNATURE----- --cmJC7u66zC7hs+87--