From owner-freebsd-net@FreeBSD.ORG Sun Jan 16 14:42:50 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 557B41065670 for ; Sun, 16 Jan 2011 14:42:50 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id D8EBF8FC22 for ; Sun, 16 Jan 2011 14:42:49 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id p0GEgmvC065457; Sun, 16 Jan 2011 15:42:48 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.4/8.14.4/Submit) id p0GEglpK065456; Sun, 16 Jan 2011 15:42:47 +0100 (CET) (envelope-from marius) Date: Sun, 16 Jan 2011 15:42:47 +0100 From: Marius Strobl To: Lev Serebryakov Message-ID: <20110116144247.GA65399@alchemy.franken.de> References: <36074996.20110112192009@serebryakov.spb.ru> <20110112213208.GD12920@michelle.cdnetworks.com> <20110112225907.GA44318@alchemy.franken.de> <20110113173925.GA49356@alchemy.franken.de> <20110113212713.GC17502@michelle.cdnetworks.com> <20110114012412.GK97101@alchemy.franken.de> <178613186.20110114134109@serebryakov.spb.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178613186.20110114134109@serebryakov.spb.ru> User-Agent: Mutt/1.4.2.3i Cc: Pyun YongHyeon , freebsd-net@freebsd.org Subject: Re: [patch] re(4) problems on networks with disabled autonegotiation "solver" (WAS: Juniper e3k with ports limitied to...) -- REQUEST FOR REVIEW X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2011 14:42:50 -0000 On Fri, Jan 14, 2011 at 01:41:09PM +0300, Lev Serebryakov wrote: > Hello, Marius. > You wrote 14 ?????? 2011 ?., 4:24:12: > > > found by ignoring the bits set in the "don't care mask". I've > > updated the patch at the above URL accordingly and based on my > > testing it now should actually work as expected. Sorry for the > > glitch. > Yes, it works for me. Thanks for testing! I've committed the patch to HEAD and will try to get it into 7.4 and 8.2. > Only one note: I think, it is good idea to document this flag in > re(4). > Technically re.4 obviously is the wrong location for documenting it as it's generally the business of the PHY drivers to handle the media. Moreover, rgephy(4) driven PHYs are also commonly used in combination with at least axe(4), nfe(4), nve(4) and sge(4) MACs so we would have to document this special media option in all of the corresponding man pages, which would introduce undesirable redundancy. So instead I've added a rgephy.4 man page and documented it there. Actually, this is a very good example for why we generally should not document media types and options in the man pages of MAC drivers that take advantage of mii(4) but instead add a common ifmedia.4 and just point there and if as in this case it makes sense to man pages of specific PHY drivers. Marius