Date: Sat, 6 Aug 2011 19:35:49 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Marius Strobl <marius@alchemy.franken.de> Cc: src-committers@FreeBSD.org, Ruslan Mahmatkhanov <cvs-src@yandex.ru>, Garrett Cooper <yanegomi@gmail.com>, svn-src-all@FreeBSD.org, Andriy Gapon <avg@FreeBSD.org>, svn-src-head@FreeBSD.org Subject: Re: svn commit: r224683 - head/lib/libthread_db Message-ID: <96C6C36B-E521-4438-9AEF-59D9A922D3B4@xcllnt.net> In-Reply-To: <20110806232415.GE48988@alchemy.franken.de> References: <201108061748.p76HmUbM061259@svn.freebsd.org> <4E3DA560.6020100@yandex.ru> <CAGH67wSFRXLRBVcoR8RME111pE7UaZ%2By-k8qmTtCkOy%2BMC3Dhw@mail.gmail.com> <4E3DBAF8.5040102@FreeBSD.org> <20110806232415.GE48988@alchemy.franken.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Aug 6, 2011, at 4:24 PM, Marius Strobl wrote: > On Sun, Aug 07, 2011 at 01:06:48AM +0300, Andriy Gapon wrote: >> on 07/08/2011 00:41 Garrett Cooper said the following: >>> It's not just i386. It's other architectures like arm, mips, and = pc98 >>> according to the tinderbox reports (this list is potentially >>> incomplete). >>=20 >> Yeah, confusingly enough thr_pread_long() is declared to take = uint64_t* as its >> third argument, so this commit breaks all platforms where uint64_t is = not >> derived from (unsigned) long. >> Just in case, thr_pread_int() takes uint32_t* as well. >>=20 >=20 > Yes, the type of val is wrong. I'm currently running a fix through a > universe build Ah, euh, ok, I forgot about this particular quirk: uint64_t is deliberate, because it's the width of long on 64-bit architectures and thread_db is to be used as a support library for a cross-tool (i.e. a 32-bit debugger for a 64-bit target). That's why thr_pread_long() takes a pointer to uint64_t and thr_pread_int() takes a pointer to uint32_t... Sorry for missing this in the review. FYI, --=20 Marcel Moolenaar marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96C6C36B-E521-4438-9AEF-59D9A922D3B4>