From owner-freebsd-hackers@freebsd.org Sat Feb 17 16:02:20 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BC498F1B8DD for ; Sat, 17 Feb 2018 16:02:20 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-qk0-x242.google.com (mail-qk0-x242.google.com [IPv6:2607:f8b0:400d:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A8F886D5A; Sat, 17 Feb 2018 16:02:20 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-qk0-x242.google.com with SMTP id g2so7440151qkd.12; Sat, 17 Feb 2018 08:02:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Qsl7oUiHG2KEboXg711eEv547emj+AHEGLvvbkb0iXA=; b=e/cNRcFZ6xcI6fzg+rrS4PG3v88CgP/Fe+RYSZ1l6Fx4MmEs43UNVHaaml+Ft88b8g 3/oE0SE1dUnFphiJVkOhAdKY775ReruAYU1SNOPycroFvl1NQE7irH7G4kuEQIZ0U089 QBppM6OKOS42MjdG3QSA12rKMQsAzdll7vIFKbrw5pIyTnUd1yTLLsNBqZY9j8gpfWXC v7ycK1Dix7UhMIgwTug2bXDXkjwPJAQ1SACoiAyunJ8VkMPzPoD+PEGi/twyURDaGr5f ireFHwex0OUkgzqR5mAFHioPHcoWX2By/IPERWg4orGWcWmD+tcZdwF7lUtndgUXj0Xm HBcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Qsl7oUiHG2KEboXg711eEv547emj+AHEGLvvbkb0iXA=; b=b9Kz0UfD7V23tqrBPg6rHdQmT4ZPPtR3GOx6aXc7FuSu1keU9SFqJNW+Nn5+DtyNo3 h7KSdzOlsZJ0UdwNjcvHE8lyJFklxQQ2o9WnY6LNsK2oTZoxq5S/OWiqqiusGkmntFwP xuXNX0yJ5VmHz9EuRD3iSvu5CC2/TUHysb84iRnmYfdmmNzoPsXYIafNQDELaqTvdNkL KLyXAVw5NLku+xgj4Tps+Uu1GUna66KsIYENh43fon2vC1UESvaWYsFsFzmZ2VfpsOS4 TH1MY9qZIyrdnFGJakFdZ2gpDSCHM+u1IL1Z7+sjCwvMC4FNQDcrJpmIOAdA5LyGfqq/ GnDA== X-Gm-Message-State: APf1xPCjF5YWMh7kRBrMsyXHq+/PnbW3XrYF7lV/1IGgoA5qSjjRx3wT G4T5LSGMX0oclLNbm5K7l2+AVRSRPd6YhqpnBHtSew== X-Google-Smtp-Source: AH8x227l70ghKLsD190Ovzy/ue01uyak6MOlgJLH+5ooHneesweeuxVp8Vi0NC+yUV4Pa/GsVysLi7yyVEB5DETTxYk= X-Received: by 10.55.74.2 with SMTP id x2mr14840672qka.314.1518883339957; Sat, 17 Feb 2018 08:02:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.58.99 with HTTP; Sat, 17 Feb 2018 08:02:19 -0800 (PST) In-Reply-To: <20180217153825.GB61118@x-wing> References: <20180217150224.GA61118@x-wing> <20180217153825.GB61118@x-wing> From: Mateusz Guzik Date: Sat, 17 Feb 2018 17:02:19 +0100 Message-ID: Subject: Re: Where KASASERT fd < fdp->fd_nfiles should be? To: Mariusz Zaborski Cc: freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Feb 2018 16:02:21 -0000 On Sat, Feb 17, 2018 at 4:38 PM, Mariusz Zaborski wrote: > So maybe we should go in more general approach and move this KASSERT to the > fget_locked and fdget_locked functions? > > If anyone is going to do anything with fd_lastfile, the right course of action is to whack it. A soft prerequisite is that someone takes care of the current hand-rolled bitmap implementation. -- Mateusz Guzik